Changeset 246222 in webkit

Timestamp:

Jun 7, 2019, 3:52:34 PM (7 years ago)

Author:

dbates@webkit.org

Message:

[lldb-webkit] Pretty-print all kinds of Documents
​https://bugs.webkit.org/show_bug.cgi?id=198620

Reviewed by Simon Fraser.

Register formatters for all classes derived from WebCore::Document so we get nice summaries
without having to drill down in Xcode- or casting- to the base class, Document.

Older LLDB versions use to do this automatically, but this functionality was removed in newer
versions:

[[

Warning: previous versions of LLDB defined cascading to mean not only going through typedef
chains, but also through inheritance chains. This feature has been removed since it
significantly degrades performance. You need to set up your formatters for every type in
inheritance chains to which you want the formatter to apply.

]]
<​https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)

• lldb/lldb_webkit.py:

(lldb_init_module):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• lldb/lldb_webkit.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-06-07  Daniel Bates  <dabates@apple.com>
+
+        [lldb-webkit] Pretty-print all kinds of Documents
+        https://bugs.webkit.org/show_bug.cgi?id=198620
+
+        Reviewed by Simon Fraser.
+
+        Register formatters for all classes derived from WebCore::Document so we get nice summaries
+        without having to drill down in Xcode- or casting- to the base class, Document.
+
+        Older LLDB versions use to do this automatically, but this functionality was removed in newer
+        versions:
+            [[
+                Warning: previous versions of LLDB defined cascading to mean not only going through typedef
+                chains, but also through inheritance chains. This feature has been removed since it
+                significantly degrades performance. You need to set up your formatters for every type in
+                inheritance chains to which you want the formatter to apply.
+            ]]
+            <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
+
+        * lldb/lldb_webkit.py:
+        (__lldb_init_module):
+
 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/lldb/lldb_webkit.py

@@ -86 +86 @@
     debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreSecurityOrigin_SummaryProvider WebCore::SecurityOrigin')
     debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreFrame_SummaryProvider WebCore::Frame')
-    debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreDocument_SummaryProvider WebCore::Document')
+
+    for className in ['Document', 'FTPDirectoryDocument', 'HTMLDocument', 'ImageDocument', 'MediaDocument', 'PluginDocument', 'SVGDocument', 'SinkDocument', 'TextDocument', 'XMLDocument']:
+        debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreDocument_SummaryProvider WebCore::' + className)
 
     # synthetic types (see <https://lldb.llvm.org/varformats.html>)