Changeset 246266 in webkit

Timestamp:

Jun 10, 2019, 10:16:18 AM (7 years ago)

Author:

Adrian Perez de Castro

Message:

[JSC] Linker fails when unified sources are not in use
​https://bugs.webkit.org/show_bug.cgi?id=198722

Reviewed by Keith Miller.

Added missing inclusions of headers in several files which make use of inline functions.

• b3/B3AtomicValue.cpp:
• b3/B3BlockInsertionSet.cpp:
• b3/B3FenceValue.cpp:
• b3/B3LowerMacrosAfterOptimizations.cpp:
• b3/B3PureCSE.cpp:
• b3/B3StackmapValue.cpp:
• b3/B3SwitchValue.cpp:
• b3/B3UseCounts.cpp:
• b3/B3VariableValue.cpp:
• b3/B3WasmAddressValue.cpp:
• b3/B3WasmBoundsCheckValue.cpp:
• ftl/FTLCompile.cpp:
• wasm/WasmSectionParser.cpp:
• wasm/WasmTable.cpp:
• wasm/WasmValidate.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• b3/B3AtomicValue.cpp (modified) (1 diff)
• b3/B3BlockInsertionSet.cpp (modified) (1 diff)
• b3/B3FenceValue.cpp (modified) (1 diff)
• b3/B3LowerMacrosAfterOptimizations.cpp (modified) (1 diff)
• b3/B3PureCSE.cpp (modified) (1 diff)
• b3/B3StackmapValue.cpp (modified) (1 diff)
• b3/B3SwitchValue.cpp (modified) (1 diff)
• b3/B3UseCounts.cpp (modified) (1 diff)
• b3/B3VariableValue.cpp (modified) (1 diff)
• b3/B3WasmAddressValue.cpp (modified) (1 diff)
• b3/B3WasmBoundsCheckValue.cpp (modified) (1 diff)
• ftl/FTLCompile.cpp (modified) (1 diff)
• wasm/WasmSectionParser.cpp (modified) (1 diff)
• wasm/WasmTable.cpp (modified) (1 diff)
• wasm/WasmValidate.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [JSC] Linker fails when unified sources are not in use
+        https://bugs.webkit.org/show_bug.cgi?id=198722
+
+        Reviewed by Keith Miller.
+
+        Added missing inclusions of headers in several files which make use of inline functions.
+
+        * b3/B3AtomicValue.cpp:
+        * b3/B3BlockInsertionSet.cpp:
+        * b3/B3FenceValue.cpp:
+        * b3/B3LowerMacrosAfterOptimizations.cpp:
+        * b3/B3PureCSE.cpp:
+        * b3/B3StackmapValue.cpp:
+        * b3/B3SwitchValue.cpp:
+        * b3/B3UseCounts.cpp:
+        * b3/B3VariableValue.cpp:
+        * b3/B3WasmAddressValue.cpp:
+        * b3/B3WasmBoundsCheckValue.cpp:
+        * ftl/FTLCompile.cpp:
+        * wasm/WasmSectionParser.cpp:
+        * wasm/WasmTable.cpp:
+        * wasm/WasmValidate.cpp:
+
 2019-06-10  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/b3/B3AtomicValue.cpp

@@ -26 +26 @@
 #include "config.h"
 #include "B3AtomicValue.h"
+#include "B3ValueInlines.h"
 
 #if ENABLE(B3_JIT)

trunk/Source/JavaScriptCore/b3/B3BlockInsertionSet.cpp

@@ -32 +32 @@
 #include "B3InsertionSet.h"
 #include "B3ProcedureInlines.h"
+#include "B3ValueInlines.h"
 #include <wtf/BubbleSort.h>
 

trunk/Source/JavaScriptCore/b3/B3FenceValue.cpp

@@ -26 +26 @@
 #include "config.h"
 #include "B3FenceValue.h"
+#include "B3ValueInlines.h"
 
 #if ENABLE(B3_JIT)

trunk/Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp

@@ -38 +38 @@
 #include "B3InsertionSetInlines.h"
 #include "B3PhaseScope.h"
+#include "B3ValueInlines.h"
 
 namespace JSC { namespace B3 {

trunk/Source/JavaScriptCore/b3/B3PureCSE.cpp

@@ -32 +32 @@
 #include "B3PhaseScope.h"
 #include "B3Value.h"
+#include "B3ValueInlines.h"
 
 namespace JSC { namespace B3 {

trunk/Source/JavaScriptCore/b3/B3StackmapValue.cpp

@@ -26 +26 @@
 #include "config.h"
 #include "B3StackmapValue.h"
+#include "B3ValueInlines.h"
 
 #if ENABLE(B3_JIT)

trunk/Source/JavaScriptCore/b3/B3SwitchValue.cpp

@@ -30 +30 @@
 
 #include "B3BasicBlockInlines.h"
+#include "B3ValueInlines.h"
 #include <wtf/ListDump.h>
 

trunk/Source/JavaScriptCore/b3/B3UseCounts.cpp

@@ -30 +30 @@
 
 #include "B3Procedure.h"
+#include "B3ValueInlines.h"
 
 namespace JSC { namespace B3 {

trunk/Source/JavaScriptCore/b3/B3VariableValue.cpp

@@ -29 +29 @@
 #if ENABLE(B3_JIT)
 
+#include "B3ValueInlines.h"
 #include "B3Variable.h"
 

trunk/Source/JavaScriptCore/b3/B3WasmAddressValue.cpp

@@ -29 +29 @@
 #if ENABLE(B3_JIT)
 
+#include "B3ValueInlines.h"
+
 namespace JSC { namespace B3 {
 

trunk/Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.cpp

@@ -29 +29 @@
 
 #if ENABLE(B3_JIT)
+
+#include "B3ValueInlines.h"
 
 namespace JSC { namespace B3 {

trunk/Source/JavaScriptCore/ftl/FTLCompile.cpp

@@ -35 +35 @@
 #include "B3StackSlot.h"
 #include "B3Value.h"
+#include "B3ValueInlines.h"
 #include "CodeBlockWithJITType.h"
 #include "CCallHelpers.h"

trunk/Source/JavaScriptCore/wasm/WasmSectionParser.cpp

@@ -31 +31 @@
 
 #include "IdentifierInlines.h"
+#include "JSCJSValueInlines.h"
 #include "WasmMemoryInformation.h"
 #include "WasmNameSectionParser.h"

trunk/Source/JavaScriptCore/wasm/WasmTable.cpp

@@ -29 +29 @@
 #if ENABLE(WEBASSEMBLY)
 
+#include "JSCJSValueInlines.h"
 #include <wtf/CheckedArithmetic.h>
 #include <wtf/StdLibExtras.h>

trunk/Source/JavaScriptCore/wasm/WasmValidate.cpp

@@ -29 +29 @@
 #if ENABLE(WEBASSEMBLY)
 
+#include "JSCJSValueInlines.h"
 #include "WasmFunctionParser.h"
 #include <wtf/CommaPrinter.h>