Changeset 246299 in webkit

Timestamp:

Jun 10, 2019, 5:38:48 PM (7 years ago)

Author:

Basuke Suzuki

Message:

[WinCairo] Remove build warning from RemoteInspector.
​https://bugs.webkit.org/show_bug.cgi?id=198724

Reviewed by Joseph Pecoraro.

In RemoteInspectorConnectionClient.h, an interface was defined with empty implementation.
This method is to be overwritten by sub classes so that parameter name is important
so they are commented out rather than just removing from the definition.

• inspector/remote/RemoteInspector.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/remote/socket/RemoteInspectorConnectionClient.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-06-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
+
+        [WinCairo] Remove build warning from RemoteInspector.
+        https://bugs.webkit.org/show_bug.cgi?id=198724
+
+        Reviewed by Joseph Pecoraro.
+
+        In `RemoteInspectorConnectionClient.h`, an interface was defined with empty implementation.
+        This method is to be overwritten by sub classes so that parameter name is important
+        so they are commented out rather than just removing from the definition.
+
+        * inspector/remote/RemoteInspector.h:
+
 2019-06-10  Sam Weinig  <weinig@apple.com>
 

trunk/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.h

@@ -38 +38 @@
 public:
     void didReceiveWebInspectorEvent(ConnectionID, Vector<uint8_t>&&);
-    virtual void didAccept(ConnectionID acceptedID, ConnectionID listenerID, Socket::Domain) { }
+    virtual void didAccept(ConnectionID /* acceptedID */, ConnectionID /* listenerID */, Socket::Domain) { }
     virtual void didClose(ConnectionID) = 0;