Changeset 246312 in webkit

Timestamp:

Jun 11, 2019, 8:13:59 AM (7 years ago)

Author:

youenn@apple.com

Message:

MediaStreamAudioSourceNode::setFormat should check for m_sourceSampleRate equality
​https://bugs.webkit.org/show_bug.cgi?id=198740
<rdar://problem/47088939>

Reviewed by Eric Carlson.

Source/WebCore:

Covered by tests that are now passing.

• Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::setFormat):

LayoutTests:

• platform/mac/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-11  Youenn Fablet  <youenn@apple.com>
+
+        MediaStreamAudioSourceNode::setFormat should check for m_sourceSampleRate equality
+        https://bugs.webkit.org/show_bug.cgi?id=198740
+        <rdar://problem/47088939>
+
+        Reviewed by Eric Carlson.
+
+        * platform/mac/TestExpectations:
+
 2019-06-11  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1933 +1933 @@
 
 # <rdar://problem/47088939>
-[ Mojave+ ] webrtc/audio-peer-connection-webaudio.html [ Failure ]
-[ Mojave+ ] webrtc/audio-replace-track.html [ Failure ]
 [ Mojave+ ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html  [ Failure ]
-[ Mojave+ ] webrtc/peer-connection-remote-audio-mute.html [ Skip ]
-[ Mojave+ ] webrtc/peer-connection-audio-mute2.html [ Failure ]
-[ Mojave+ ] webrtc/peer-connection-audio-mute.html [ Skip ]
-[ Mojave+ ] webrtc/peer-connection-remote-audio-mute2.html [ Pass Failure ]
 [ Mojave+ ] webaudio/realtimeanalyser-fft-scaling.html [ Pass Failure ]
 [ Mojave+ ] webaudio/oscillator-sine.html [ Skip ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-11  Youenn Fablet  <youenn@apple.com>
+
+        MediaStreamAudioSourceNode::setFormat should check for m_sourceSampleRate equality
+        https://bugs.webkit.org/show_bug.cgi?id=198740
+        <rdar://problem/47088939>
+
+        Reviewed by Eric Carlson.
+
+        Covered by tests that are now passing.
+
+        * Modules/webaudio/MediaStreamAudioSourceNode.cpp:
+        (WebCore::MediaStreamAudioSourceNode::setFormat):
+
 2019-06-11  Ludovico de Nittis  <ludovico.denittis@collabora.com>
 

trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp

@@ -73 +73 @@
 {
     float sampleRate = this->sampleRate();
-    if (numberOfChannels == m_sourceNumberOfChannels && sourceSampleRate == sampleRate)
+    if (numberOfChannels == m_sourceNumberOfChannels && sourceSampleRate == m_sourceSampleRate)
         return;