Changeset 246328 in webkit

Timestamp:

Jun 11, 2019, 12:33:57 PM (7 years ago)

Author:

Michael Catanzaro

Message:

Unreviewed build warning fixes

Source/JavaScriptCore:

Silence -Wreturn-type warning

• wasm/WasmTable.cpp:

(JSC::Wasm::Table::tryCreate):

Source/WebCore:

Silence -Wunused-parameter warning

• testing/Internals.cpp:

(WebCore::Internals::storeRegistrationsOnDisk):

Source/WebKit:

Silence -Wunused-variable warning

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::clearWebProcessIsPlayingAudibleMedia):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/wasm/WasmTable.cpp (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/testing/Internals.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/WebProcessPool.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed build warning fixes
+
+        Silence -Wreturn-type warning
+
+        * wasm/WasmTable.cpp:
+        (JSC::Wasm::Table::tryCreate):
+
 2019-06-11  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/wasm/WasmTable.cpp

@@ -77 +77 @@
         return adoptRef(new Table(initial, maximum));
     }
+
+    RELEASE_ASSERT_NOT_REACHED();
 }
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed build warning fixes
+
+        Silence -Wunused-parameter warning
+
+        * testing/Internals.cpp:
+        (WebCore::Internals::storeRegistrationsOnDisk):
+
 2019-06-10  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/testing/Internals.cpp

@@ -4807 +4807 @@
         promise.resolve();
     });
+#else
+    promise.resolve();
 #endif
 }

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed build warning fixes
+
+        Silence -Wunused-variable warning
+
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::clearWebProcessIsPlayingAudibleMedia):
+
 2019-06-10  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

@@ -2598 +2598 @@
 
     auto* process = WebProcessProxy::processForIdentifier(processID);
-    ASSERT(process);
+    ASSERT_UNUSED(process, process);
+
     RELEASE_LOG(ProcessSuspension, "Web process pid %u is no longer playing audible media", (unsigned)process->processIdentifier());