Changeset 246386 in webkit

Timestamp:

Jun 12, 2019, 4:07:57 PM (7 years ago)

Author:

dbates@webkit.org

Message:

[iOS] Adjust tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html following r243808
​https://bugs.webkit.org/show_bug.cgi?id=198799
<rdar://problem/50181023>

Reviewed by Brent Fulgham.

Following r243808 we no longer defocus a <select> on iPad when its popover is dismissed as a
result of picking a value for it. This is to make the behavior of <select> on iPad like the Mac.
However the tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html
depend on the old behavior. So, we need to update them to no longer expect a defocusing of the
<select>/the end of form control interaction.

• platform/ipad/fast/forms/select-form-run-twice.html:
• platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/ipad/fast/forms/select-form-run-twice.html (modified) (1 diff)
• platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-12  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Adjust tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html following r243808
+        https://bugs.webkit.org/show_bug.cgi?id=198799
+        <rdar://problem/50181023>
+
+        Reviewed by Brent Fulgham.
+
+        Following r243808 we no longer defocus a <select> on iPad when its popover is dismissed as a
+        result of picking a value for it. This is to make the behavior of <select> on iPad like the Mac. 
+        However the tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html
+        depend on the old behavior. So, we need to update them to no longer expect a defocusing of the
+        <select>/the end of form control interaction.
+
+        * platform/ipad/fast/forms/select-form-run-twice.html:
+        * platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html:
+
 2019-06-12  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html

@@ -54 +54 @@
                     uiController.didStartFormControlInteractionCallback = function() {
                         uiController.selectFormAccessoryPickerRow(${row});
-                    };
-
-                    uiController.didEndFormControlInteractionCallback = function() {
                         uiController.uiScriptComplete();
                     };

trunk/LayoutTests/platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html

@@ -54 +54 @@
                     uiController.didStartFormControlInteractionCallback = function() {
                         uiController.selectFormAccessoryPickerRow(5);
-                    };
-
-                    uiController.didEndFormControlInteractionCallback = function() {
                         uiController.uiScriptComplete();
                     };