Changeset 246439 in webkit

Timestamp:

Jun 14, 2019, 11:59:18 AM (7 years ago)

Author:

sbarati@apple.com

Message:

Unreviewed. Follow up to r246438. This removes a debug assert until
we do further compiler work in: ​https://bugs.webkit.org/show_bug.cgi?id=198861

• Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:

(WebCore::WHLSL::checkDuplicateFunctions):

• Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp (modified) (1 diff)
• Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-14  Saam Barati  <sbarati@apple.com>
+
+        Unreviewed. Follow up to r246438. This removes a debug assert until
+        we do further compiler work in: https://bugs.webkit.org/show_bug.cgi?id=198861
+
+        * Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
+        (WebCore::WHLSL::checkDuplicateFunctions):
+        * Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:
+
 2019-06-14  Saam Barati  <sbarati@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp

@@ -167 +167 @@
         // Since we do that, we just need to make sure no native function is a duplicate
         // of a user-defined function.
-        ASSERT(passesStaticChecks(nativeFunctionDeclaration.get()));
+
+        // FIXME: Add back this assert once we begin to auto generate these in the compiler
+        // instead of having them in the stdlib
+        // https://bugs.webkit.org/show_bug.cgi?id=198861
+        // ASSERT(passesStaticChecks(nativeFunctionDeclaration.get()));
         if (functions.contains(DuplicateFunctionKey { nativeFunctionDeclaration.get() }))
             return false;

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt

@@ -442 +442 @@
 native bool operator==(float, float);
 native bool operator==(int, int);
+native float operator*(float, float);
+
+// FIXME: These should be auto generated by the compiler.
+// https://bugs.webkit.org/show_bug.cgi?id=198861
 native bool operator==(thread int*, thread int*);
-native float operator*(float, float);
 
 native bool operator.x(bool2);