Changeset 246462 in webkit

Timestamp:

Jun 15, 2019, 7:13:55 AM (7 years ago)

Author:

Alan Bujtas

Message:

[LFC[MarginCollapsing] Anonymous boxes never collapse their margins with siblings.
​https://bugs.webkit.org/show_bug.cgi?id=198884
<rdar://problem/51773509>

Reviewed by Antti Koivisto.

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/blockformatting/BlockMarginCollapse.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-15  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC[MarginCollapsing] Anonymous boxes never collapse their margins with siblings.
+        https://bugs.webkit.org/show_bug.cgi?id=198884
+        <rdar://problem/51773509>
+
+        Reviewed by Antti Koivisto.
+
+        * layout/blockformatting/BlockMarginCollapse.cpp:
+        (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):
+
 2019-06-15  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp

@@ -159 +159 @@
 
     auto& previousInFlowSibling = *layoutBox.previousInFlowSibling();
+    if (previousInFlowSibling.isAnonymous())
+        return false;
+
     // Margins between a floated box and any other box do not collapse.
     if (layoutBox.isFloatingPositioned() || previousInFlowSibling.isFloatingPositioned())