Changeset 246463 in webkit

Timestamp:

Jun 15, 2019, 7:16:13 AM (7 years ago)

Author:

Alan Bujtas

Message:

[LFC][MarginCollapsing] Collapsed through margin values preserve quirk state.
​https://bugs.webkit.org/show_bug.cgi?id=198885
<rdar://problem/51773568>

Reviewed by Antti Koivisto.

The collapsed through margin becomes a quirk margin if either of the vertical(before/after) margins have quirk value.

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::computedPositiveAndNegativeMargin):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/blockformatting/BlockMarginCollapse.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-15  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][MarginCollapsing] Collapsed through margin values preserve quirk state.
+        https://bugs.webkit.org/show_bug.cgi?id=198885
+        <rdar://problem/51773568>
+
+        Reviewed by Antti Koivisto.
+
+        The collapsed through margin becomes a quirk margin if either of the vertical(before/after) margins have quirk value.
+
+        * layout/blockformatting/BlockMarginCollapse.cpp:
+        (WebCore::Layout::computedPositiveAndNegativeMargin):
+
 2019-06-15  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp

@@ -452 +452 @@
 
     if (a.isNonZero() && b.isNonZero())
-        computedValues.isQuirk = a.isQuirk && b.isQuirk;
+        computedValues.isQuirk = a.isQuirk || b.isQuirk;
     else if (a.isNonZero())
         computedValues.isQuirk = a.isQuirk;