Changeset 246618 in webkit

Timestamp:

Jun 19, 2019, 5:15:55 PM (7 years ago)

Author:

Matt Baker

Message:

Web Inspector: Remove unused _pendingFilter from NetworkTableContentView
​https://bugs.webkit.org/show_bug.cgi?id=199026

Reviewed by Devin Rousso.

This flag is no longer set as of ​https://trac.webkit.org/changeset/225895.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype._processPendingEntries):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/NetworkTableContentView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-06-19  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Remove unused _pendingFilter from NetworkTableContentView
+        https://bugs.webkit.org/show_bug.cgi?id=199026
+
+        Reviewed by Devin Rousso.
+
+        This flag is no longer set as of https://trac.webkit.org/changeset/225895.
+
+        * UserInterface/Views/NetworkTableContentView.js:
+        (WI.NetworkTableContentView):
+        (WI.NetworkTableContentView.prototype._processPendingEntries):
+
 2019-06-19  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js

@@ -40 +40 @@
         this._entriesSortComparator = null;
 
-        this._pendingFilter = false;
         this._showingRepresentedObjectCookie = null;
 
@@ -1334 +1333 @@
         let collection = this._activeCollection;
         let needsSort = collection.pendingUpdates.length > 0;
-        let needsFilter = this._pendingFilter;
-
-        // No global sort or filter is needed, so just insert new records into their sorted position.
-        if (!needsSort && !needsFilter) {
+
+        // No global sort is needed, so just insert new records into their sorted position.
+        if (!needsSort) {
             let originalLength = collection.pendingInsertions.length;
             for (let resource of collection.pendingInsertions)
@@ -1358 +1356 @@
         }
         collection.pendingUpdates = [];
-
-        this._pendingFilter = false;
 
         this._updateSort();