Changeset 246922 in webkit


Ignore:
Timestamp:
Jun 28, 2019 12:38:09 AM (5 years ago)
Author:
Fujii Hironori
Message:

[Win] unresolved external symbol "JSC::JSObject::didBecomePrototype(void)" referenced in function "JSC::Structure::create(...)"
​https://bugs.webkit.org/show_bug.cgi?id=199312

Reviewed by Keith Miller.

WinCairo port, clang-cl Release builds reported a following linkage error:

WebCore.lib(UnifiedSource-4babe430-10.cpp.obj) : error LNK2019: unresolved external symbol "public: void cdecl JSC::JSObject::didBecomePrototype(void)" (?didBecomePrototype@JSObject@JSC@@QEAAXXZ) referenced in function "public: static class JSC::Structure * cdecl JSC::Structure::create(class JSC::VM &,class JSC::JSGlobalObject *,class JSC::JSValue,class JSC::TypeInfo const &,struct JSC::ClassInfo const *,unsigned char,unsigned int)" (?create@Structure@JSC@@SAPEAV12@AEAVVM@2@PEAVJSGlobalObject@2@VJSValue@2@AEBVTypeInfo@2@PEBUClassInfo@2@EI@Z)

No new tests because there is no behavior change.

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: Include <JavaScriptCore/JSCInlines.h>,

and do not include headers which is included by it.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r246920 r246922  
     12019-06-28  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [Win] unresolved external symbol "JSC::JSObject::didBecomePrototype(void)" referenced in function "JSC::Structure::create(...)"
     4        https://bugs.webkit.org/show_bug.cgi?id=199312
     5
     6        Reviewed by Keith Miller.
     7
     8        WinCairo port, clang-cl Release builds reported a following linkage error:
     9
     10        > WebCore.lib(UnifiedSource-4babe430-10.cpp.obj) : error LNK2019: unresolved external symbol "public: void __cdecl JSC::JSObject::didBecomePrototype(void)" (?didBecomePrototype@JSObject@JSC@@QEAAXXZ) referenced in function "public: static class JSC::Structure * __cdecl JSC::Structure::create(class JSC::VM &,class JSC::JSGlobalObject *,class JSC::JSValue,class JSC::TypeInfo const &,struct JSC::ClassInfo const *,unsigned char,unsigned int)" (?create@Structure@JSC@@SAPEAV12@AEAVVM@2@PEAVJSGlobalObject@2@VJSValue@2@AEBVTypeInfo@2@PEBUClassInfo@2@EI@Z)
     11
     12        No new tests because there is no behavior change.
     13
     14        * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: Include <JavaScriptCore/JSCInlines.h>,
     15        and do not include headers which is included by it.
     16
    1172019-06-27  Zalan Bujtas  <zalan@apple.com>
    218

  • trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp

    r244687 r246922  
    5050#include "ThreadSafeDataBuffer.h"
    5151#include <JavaScriptCore/AuxiliaryBarrierInlines.h>
    52 #include <JavaScriptCore/HeapInlines.h>
    53 #include <JavaScriptCore/JSCJSValueInlines.h>
    54 #include <JavaScriptCore/JSGlobalObject.h>
     52#include <JavaScriptCore/JSCInlines.h>
    5553#include <JavaScriptCore/StrongInlines.h>
    56 #include <JavaScriptCore/StructureInlines.h>
    5754#include <wtf/FileSystem.h>
    5855#include <wtf/NeverDestroyed.h>
Note: See TracChangeset for help on using the changeset viewer.