Changeset 247730 in webkit

Timestamp:

Jul 23, 2019 12:06:30 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Long press hint of AirPods buy buttons are tall and narrow during animation
​https://bugs.webkit.org/show_bug.cgi?id=200036
<rdar://problem/53145697>

Reviewed by Wenson Hsieh.

Source/WebCore:

New test: fast/text-indicator/text-indicator-with-tiny-child.html

• dom/Range.cpp:

(WebCore::Range::borderAndTextRects const):

• dom/Range.h:

Add a BoundingRectBehavior that ignores 1x1 and smaller rects.

• page/TextIndicator.cpp:

(WebCore::absoluteBoundingRectForRange):
Enable IgnoreTinyRects.

LayoutTests:

• fast/text-indicator/text-indicator-with-tiny-child-expected.txt: Added.
• fast/text-indicator/text-indicator-with-tiny-child.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text-indicator/text-indicator-with-tiny-child-expected.txt (added)
• LayoutTests/fast/text-indicator/text-indicator-with-tiny-child.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Range.cpp (modified) (1 diff)
• Source/WebCore/dom/Range.h (modified) (1 diff)
• Source/WebCore/page/TextIndicator.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-07-23  Tim Horton  <timothy_horton@apple.com>
+
+        Long press hint of AirPods buy buttons are tall and narrow during animation
+        https://bugs.webkit.org/show_bug.cgi?id=200036
+        <rdar://problem/53145697>
+
+        Reviewed by Wenson Hsieh.
+
+        * fast/text-indicator/text-indicator-with-tiny-child-expected.txt: Added.
+        * fast/text-indicator/text-indicator-with-tiny-child.html: Added.
+
 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-23  Tim Horton  <timothy_horton@apple.com>
+
+        Long press hint of AirPods buy buttons are tall and narrow during animation
+        https://bugs.webkit.org/show_bug.cgi?id=200036
+        <rdar://problem/53145697>
+
+        Reviewed by Wenson Hsieh.
+
+        New test: fast/text-indicator/text-indicator-with-tiny-child.html
+
+        * dom/Range.cpp:
+        (WebCore::Range::borderAndTextRects const):
+        * dom/Range.h:
+        Add a BoundingRectBehavior that ignores 1x1 and smaller rects.
+
+        * page/TextIndicator.cpp:
+        (WebCore::absoluteBoundingRectForRange):
+        Enable IgnoreTinyRects.
+
 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/dom/Range.cpp

@@ -1854 +1854 @@
     }
 
+    if (rectOptions.contains(BoundingRectBehavior::IgnoreTinyRects)) {
+        rects.removeAllMatching([&] (const FloatRect& rect) -> bool {
+            return rect.area() <= 1;
+        });
+    }
+
     return rects;
 }

trunk/Source/WebCore/dom/Range.h

@@ -120 +120 @@
         RespectClipping = 1 << 0,
         UseVisibleBounds = 1 << 1,
+        IgnoreTinyRects = 1 << 2,
     };
 

trunk/Source/WebCore/page/TextIndicator.cpp

@@ -227 +227 @@
     return range.absoluteBoundingRect({
         Range::BoundingRectBehavior::RespectClipping,
-        Range::BoundingRectBehavior::UseVisibleBounds
+        Range::BoundingRectBehavior::UseVisibleBounds,
+        Range::BoundingRectBehavior::IgnoreTinyRects,
     });
 }