⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 247837 in webkit


Ignore:
Timestamp:
Jul 25, 2019, 1:53:57 PM (7 years ago)
Author:
dino@apple.com
Message:

Add helper for ignoring deprecated implementation warnings
​https://bugs.webkit.org/show_bug.cgi?id=200135

Reviewed by Wenson Hsieh.

Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which
is IGNORE_WARNINGS_BEGIN("deprecated-implementations")

Source/WebCore:

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[WebAccessibilityObjectWrapper accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper IGNORE_WARNINGS_END]): Deleted.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParserWillProvideContentKeyRequestInitializationData:forTrackID:]):
(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]):

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):

Source/WebKit:

  • UIProcess/API/Cocoa/LegacyBundleForClass.mm:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(IGNORE_WARNINGS_BEGIN): Deleted.

  • UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:

(IGNORE_WARNINGS_BEGIN): Deleted.

  • UIProcess/API/Cocoa/WKConnection.mm:

(IGNORE_WARNINGS_BEGIN): Deleted.

  • UIProcess/API/Cocoa/WKPreviewElementInfo.mm:
  • UIProcess/API/Cocoa/WKProcessGroup.mm:

(IGNORE_WARNINGS_BEGIN): Deleted.

  • UIProcess/API/Cocoa/WKTypeRefWrapper.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKWebView draggedImage:endedAt:operation:]):
(-[WKWebView accessibilityAttributeValue:]):
(-[WKWebView accessibilityAttributeValue:forParameter:]):
(-[WKWebView namesOfPromisedFilesDroppedAtDestination:]):
(-[WKWebView IGNORE_WARNINGS_END]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKWebViewConfiguration _setWebsiteDataStore:]):
(-[WKWebViewConfiguration IGNORE_WARNINGS_END]): Deleted.

  • UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
  • UIProcess/API/mac/WKView.mm:

(-[WKView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKView draggedImage:endedAt:operation:]):
(-[WKView accessibilityAttributeValue:]):
(-[WKView accessibilityAttributeValue:forParameter:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
(-[WKView IGNORE_WARNINGS_END]): Deleted.

  • UIProcess/WKImagePreviewViewController.mm:

(-[WKImagePreviewViewController ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKImagePreviewViewController IGNORE_WARNINGS_END]): Deleted.

  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]):

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel popoverControllerDidDismissPopover:]):

  • UIProcess/ios/forms/WKFormPopover.mm:

(-[WKRotatingPopover popoverControllerDidDismissPopover:]):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFPluginAccessibilityObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:forParameter:]):
(-[WKPDFPluginAccessibilityObject accessibilityPerformAction:]):
(-[WKPDFPluginAccessibilityObject accessibilityIsAttributeSettable:]):
(-[WKPDFPluginAccessibilityObject accessibilitySetValue:forAttribute:]):
(-[WKPDFPluginAccessibilityObject IGNORE_WARNINGS_END]): Deleted.

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

(-[WKAccessibilityWebPageObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKAccessibilityWebPageObject accessibilityIsAttributeSettable:]):
(-[WKAccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
(-[WKAccessibilityWebPageObject IGNORE_WARNINGS_END]): Deleted.

Source/WebKitLegacy/mac:

  • Misc/WebDownload.mm:

(-[WebDownload initWithRequest:delegate:]):

  • Misc/WebIconDatabase.mm:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebBaseNetscapePluginView IGNORE_WARNINGS_END]): Deleted.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebDynamicScrollBarsView IGNORE_WARNINGS_END]): Deleted.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView draggingSourceOperationMaskForLocal:]):
(-[WebHTMLView draggedImage:endedAt:operation:]):
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
(-[WebHTMLView accessibilityAttributeValue:]):
(-[WebHTMLView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebHTMLView characterIndexForPoint:]):
(-[WebHTMLView firstRectForCharacterRange:]):
(-[WebHTMLView attributedSubstringFromRange:]):
(-[WebHTMLView setMarkedText:selectedRange:]):
(-[WebHTMLView doCommandBySelector:]):
(-[WebHTMLView insertText:]):
(-[WebHTMLView IGNORE_WARNINGS_END]): Deleted.

Source/WTF:

  • wtf/Compiler.h:
Location:
trunk/Source
Files:
30 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WTF/ChangeLog

    r247815 r247837  
     12019-07-25  Dean Jackson  <dino@apple.com>
     2
     3        Add helper for ignoring deprecated implementation warnings
     4        https://bugs.webkit.org/show_bug.cgi?id=200135
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which
     9        is IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     10
     11        * wtf/Compiler.h:
     12
    1132019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
    214

  • trunk/Source/WTF/wtf/Compiler.h

    r246789 r247837  
    448448#define ALLOW_DEPRECATED_DECLARATIONS_END IGNORE_WARNINGS_END
    449449
     450#define ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     451#define ALLOW_DEPRECATED_IMPLEMENTATIONS_END IGNORE_WARNINGS_END
     452
    450453#define ALLOW_NEW_API_WITHOUT_GUARDS_BEGIN IGNORE_CLANG_WARNINGS_BEGIN("unguarded-availability-new")
    451454#define ALLOW_NEW_API_WITHOUT_GUARDS_END IGNORE_CLANG_WARNINGS_END

  • trunk/Source/WebCore/ChangeLog

    r247836 r247837  
     12019-07-25  Dean Jackson  <dino@apple.com>
     2
     3        Add helper for ignoring deprecated implementation warnings
     4        https://bugs.webkit.org/show_bug.cgi?id=200135
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which
     9        is IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     10
     11        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
     12        (-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
     13        (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
     14        (-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
     15        (-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
     16        (-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
     17        (-[WebAccessibilityObjectWrapper accessibilityActionDescription:]):
     18        (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
     19        (-[WebAccessibilityObjectWrapper IGNORE_WARNINGS_END]): Deleted.
     20        * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
     21        (-[WebAVStreamDataParserListener streamDataParserWillProvideContentKeyRequestInitializationData:forTrackID:]):
     22        (-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]):
     23        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
     24        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
     25        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
     26
    1272019-07-25  Saam Barati  <sbarati@apple.com>
    228

  • trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

    r247677 r247837  
    13111311}
    13121312
    1313 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     1313ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    13141314- (NSArray*)accessibilityActionNames
    1315 IGNORE_WARNINGS_END
     1315ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    13161316{
    13171317    if (![self updateObjectBackingStore])
    … …  
    14471447}
    14481448
    1449 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     1449ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    14501450- (NSArray*)accessibilityAttributeNames
    1451 IGNORE_WARNINGS_END
     1451ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    14521452{
    14531453    if (![self updateObjectBackingStore])
    … …  
    26192619// suggestions: Use a hash table that maps attribute names to function calls,
    26202620// or maybe pointers to member functions
    2621 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     2621ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    26222622- (id)accessibilityAttributeValue:(NSString*)attributeName
    2623 IGNORE_WARNINGS_END
     2623ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    26242624{
    26252625    if (![self updateObjectBackingStore])
    … …  
    35023502}
    35033503
    3504 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     3504ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    35053505- (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName
    3506 IGNORE_WARNINGS_END
     3506ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    35073507{
    35083508    if (![self updateObjectBackingStore])
    … …  
    35573557//
    35583558// Registering an object is also required for observing notifications. Only registered objects can be observed.
    3559 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     3559ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    35603560- (BOOL)accessibilityIsIgnored
    3561 IGNORE_WARNINGS_END
     3561ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    35623562{
    35633563    if (![self updateObjectBackingStore])
    … …  
    35693569}
    35703570
    3571 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     3571ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    35723572- (NSArray* )accessibilityParameterizedAttributeNames
    3573 IGNORE_WARNINGS_END
     3573ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    35743574{
    35753575    if (![self updateObjectBackingStore])
    … …  
    37903790}
    37913791
    3792 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     3792ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    37933793- (void)accessibilityPerformAction:(NSString*)action
    3794 IGNORE_WARNINGS_END
     3794ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    37953795{
    37963796    if (![self updateObjectBackingStore])
    … …  
    38393839}
    38403840
    3841 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     3841ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    38423842- (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName
    3843 IGNORE_WARNINGS_END
     3843ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    38443844{
    38453845#if PLATFORM(MAC)
    … …  
    39643964}
    39653965
    3966 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     3966ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    39673967- (NSString*)accessibilityActionDescription:(NSString*)action
    3968 IGNORE_WARNINGS_END
     3968ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    39693969{
    39703970    // we have no custom actions
    … …  
    40954095#endif
    40964096
    4097 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4097ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    40984098- (id)accessibilityAttributeValue:(NSString*)attribute forParameter:(id)parameter
    4099 IGNORE_WARNINGS_END
     4099ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    41004100{
    41014101    id textMarker = nil;

  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm

    r247133 r247837  
    177177}
    178178
    179 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     179ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    180180- (void)streamDataParserWillProvideContentKeyRequestInitializationData:(AVStreamDataParser *)streamDataParser forTrackID:(CMPersistentTrackID)trackID
    181 IGNORE_WARNINGS_END
     181ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    182182{
    183183    ASSERT_UNUSED(streamDataParser, streamDataParser == _parser);
    … …  
    203203}
    204204
    205 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     205ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    206206- (void)streamDataParser:(AVStreamDataParser *)streamDataParser didProvideContentKeyRequestInitializationData:(NSData *)initData forTrackID:(CMPersistentTrackID)trackID
    207 IGNORE_WARNINGS_END
     207ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    208208{
    209209    ASSERT_UNUSED(streamDataParser, streamDataParser == _parser);

  • trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm

    r244813 r247837  
    169169}
    170170
    171 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     171ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    172172- (void)connection:(NSURLConnection *)connection didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge
    173 IGNORE_WARNINGS_END
     173ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    174174{
    175175    ASSERT(!isMainThread());
    … …  
    189189}
    190190
    191 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     191ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    192192- (BOOL)connection:(NSURLConnection *)connection canAuthenticateAgainstProtectionSpace:(NSURLProtectionSpace *)protectionSpace
    193 IGNORE_WARNINGS_END
     193ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    194194{
    195195    ASSERT(!isMainThread());

  • trunk/Source/WebKit/ChangeLog

    r247831 r247837  
     12019-07-25  Dean Jackson  <dino@apple.com>
     2
     3        Add helper for ignoring deprecated implementation warnings
     4        https://bugs.webkit.org/show_bug.cgi?id=200135
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which
     9        is IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     10
     11        * UIProcess/API/Cocoa/LegacyBundleForClass.mm:
     12        * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
     13        (IGNORE_WARNINGS_BEGIN): Deleted.
     14        * UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
     15        (IGNORE_WARNINGS_BEGIN): Deleted.
     16        * UIProcess/API/Cocoa/WKConnection.mm:
     17        (IGNORE_WARNINGS_BEGIN): Deleted.
     18        * UIProcess/API/Cocoa/WKPreviewElementInfo.mm:
     19        * UIProcess/API/Cocoa/WKProcessGroup.mm:
     20        (IGNORE_WARNINGS_BEGIN): Deleted.
     21        * UIProcess/API/Cocoa/WKTypeRefWrapper.mm:
     22        * UIProcess/API/Cocoa/WKWebView.mm:
     23        (-[WKWebView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
     24        (-[WKWebView draggedImage:endedAt:operation:]):
     25        (-[WKWebView accessibilityAttributeValue:]):
     26        (-[WKWebView accessibilityAttributeValue:forParameter:]):
     27        (-[WKWebView namesOfPromisedFilesDroppedAtDestination:]):
     28        (-[WKWebView IGNORE_WARNINGS_END]): Deleted.
     29        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
     30        (-[WKWebViewConfiguration ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
     31        (-[WKWebViewConfiguration _setWebsiteDataStore:]):
     32        (-[WKWebViewConfiguration IGNORE_WARNINGS_END]): Deleted.
     33        * UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
     34        * UIProcess/API/mac/WKView.mm:
     35        (-[WKView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
     36        (-[WKView draggedImage:endedAt:operation:]):
     37        (-[WKView accessibilityAttributeValue:]):
     38        (-[WKView accessibilityAttributeValue:forParameter:]):
     39        (-[WKView namesOfPromisedFilesDroppedAtDestination:]):
     40        (-[WKView IGNORE_WARNINGS_END]): Deleted.
     41        * UIProcess/WKImagePreviewViewController.mm:
     42        (-[WKImagePreviewViewController ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
     43        (-[WKImagePreviewViewController IGNORE_WARNINGS_END]): Deleted.
     44        * UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
     45        (-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]):
     46        * UIProcess/ios/forms/WKFileUploadPanel.mm:
     47        (-[WKFileUploadPanel popoverControllerDidDismissPopover:]):
     48        * UIProcess/ios/forms/WKFormPopover.mm:
     49        (-[WKRotatingPopover popoverControllerDidDismissPopover:]):
     50        * WebProcess/Plugins/PDF/PDFPlugin.mm:
     51        (-[WKPDFPluginAccessibilityObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
     52        (-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]):
     53        (-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:forParameter:]):
     54        (-[WKPDFPluginAccessibilityObject accessibilityPerformAction:]):
     55        (-[WKPDFPluginAccessibilityObject accessibilityIsAttributeSettable:]):
     56        (-[WKPDFPluginAccessibilityObject accessibilitySetValue:forAttribute:]):
     57        (-[WKPDFPluginAccessibilityObject IGNORE_WARNINGS_END]): Deleted.
     58        * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
     59        (-[WKAccessibilityWebPageObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
     60        (-[WKAccessibilityWebPageObject accessibilityIsAttributeSettable:]):
     61        (-[WKAccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
     62        (-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
     63        (-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
     64        (-[WKAccessibilityWebPageObject IGNORE_WARNINGS_END]): Deleted.
     65
    1662019-07-25  Youenn Fablet  <youenn@apple.com>
    267

  • trunk/Source/WebKit/UIProcess/API/Cocoa/LegacyBundleForClass.mm

    r236903 r247837  
    3939@end
    4040
    41 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     41ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    4242DEFINE_BUNDLE_FOR_CLASS(WebArchive)
    4343DEFINE_BUNDLE_FOR_CLASS(WebResource)
    44 IGNORE_WARNINGS_END
     44ALLOW_DEPRECATED_IMPLEMENTATIONS_END

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm

    r246236 r247837  
    7171NSString * const WKActionCanShowMIMETypeKey = @"WKActionCanShowMIMETypeKey";
    7272
    73 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     73ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    7474@implementation WKBrowsingContextController {
    75 IGNORE_WARNINGS_END
     75ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    7676    RefPtr<WebKit::WebPageProxy> _page;
    7777    std::unique_ptr<WebKit::PageLoadStateObserver> _pageLoadStateObserver;
    … …  
    620620
    621621ALLOW_DEPRECATED_DECLARATIONS_BEGIN
    622 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     622ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    623623@implementation WKBrowsingContextController (Private)
    624 IGNORE_WARNINGS_END
     624ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    625625
    626626- (WKPageRef)_pageRef

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm

    r242339 r247837  
    4141#import <wtf/Vector.h>
    4242
    43 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     43ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    4444@implementation WKBrowsingContextGroup {
    45 IGNORE_WARNINGS_END
     45ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    4646    API::ObjectStorage<WebKit::WebPageGroup> _pageGroup;
    4747}
    … …  
    177177
    178178ALLOW_DEPRECATED_DECLARATIONS_BEGIN
    179 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     179ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    180180@implementation WKBrowsingContextGroup (Private)
    181 IGNORE_WARNINGS_END
     181ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    182182
    183183- (WKPageGroupRef)_pageGroupRef

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm

    r242339 r247837  
    3535#import <wtf/text/WTFString.h>
    3636
    37 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     37ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    3838@implementation WKConnection {
    39 IGNORE_WARNINGS_END
     39ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    4040    WeakObjCPtr<id <WKConnectionDelegate>> _delegate;
    4141}

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreviewElementInfo.mm

    r245691 r247837  
    2929#if PLATFORM(IOS_FAMILY)
    3030
    31 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     31ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    3232@implementation WKPreviewElementInfo
    33 IGNORE_WARNINGS_END
     33ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    3434
    3535- (instancetype)_initWithLinkURL:(NSURL *)url

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm

    r243417 r247837  
    5151#endif
    5252
    53 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     53ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    5454@implementation WKProcessGroup {
    55 IGNORE_WARNINGS_END
     55ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    5656    RefPtr<WebKit::WebProcessPool> _processPool;
    5757
    … …  
    226226
    227227ALLOW_DEPRECATED_DECLARATIONS_BEGIN
    228 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     228ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    229229@implementation WKProcessGroup (Private)
    230 IGNORE_WARNINGS_END
     230ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    231231
    232232- (WKContextRef)_contextRef

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKTypeRefWrapper.mm

    r242339 r247837  
    3535@end
    3636
    37 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     37ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    3838@implementation WKTypeRefWrapper
    39 IGNORE_WARNINGS_END
     39ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    4040
    4141- (id)initWithObject:(WKTypeRef)object

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

    r247746 r247837  
    35733573}
    35743574
    3575 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     3575ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    35763576- (void)renewGState
    3577 IGNORE_WARNINGS_END
     3577ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    35783578{
    35793579    _impl->renewGState();
    … …  
    40694069
    40704070#if ENABLE(DRAG_SUPPORT)
    4071 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4071ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    40724072- (void)draggedImage:(NSImage *)image endedAt:(NSPoint)endPoint operation:(NSDragOperation)operation
    4073 IGNORE_WARNINGS_END
     4073ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    40744074{
    40754075    _impl->draggedImage(image, NSPointToCGPoint(endPoint), operation);
    … …  
    41624162}
    41634163
    4164 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4164ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    41654165- (BOOL)accessibilityIsIgnored
    4166 IGNORE_WARNINGS_END
     4166ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    41674167{
    41684168    return _impl->accessibilityIsIgnored();
    … …  
    41744174}
    41754175
    4176 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4176ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    41774177- (id)accessibilityAttributeValue:(NSString *)attribute
    4178 IGNORE_WARNINGS_END
     4178ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    41794179{
    41804180    return _impl->accessibilityAttributeValue(attribute);
    41814181}
    41824182
    4183 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4183ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    41844184- (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter
    4185 IGNORE_WARNINGS_END
     4185ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    41864186{
    41874187    return _impl->accessibilityAttributeValue(attribute, parameter);
    41884188}
    41894189
    4190 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4190ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    41914191- (NSArray<NSString *> *)accessibilityParameterizedAttributeNames
    4192 IGNORE_WARNINGS_END
     4192ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    41934193{
    41944194    NSArray<NSString *> *names = [super accessibilityParameterizedAttributeNames];
    … …  
    42614261}
    42624262
    4263 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4263ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    42644264- (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
    4265 IGNORE_WARNINGS_END
     4265ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    42664266{
    42674267    return _impl->namesOfPromisedFilesDroppedAtDestination(dropDestination);

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm

    r246657 r247837  
    554554ALLOW_DEPRECATED_DECLARATIONS_BEGIN
    555555
    556 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     556ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    557557- (_WKWebsiteDataStore *)_websiteDataStore
    558 IGNORE_WARNINGS_END
     558ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    559559{
    560560    return self.websiteDataStore ? adoptNS([[_WKWebsiteDataStore alloc] initWithDataStore:self.websiteDataStore]).autorelease() : nullptr;
    561561}
    562562
    563 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     563ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    564564- (void)_setWebsiteDataStore:(_WKWebsiteDataStore *)websiteDataStore
    565 IGNORE_WARNINGS_END
     565ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    566566{
    567567    self.websiteDataStore = websiteDataStore ? websiteDataStore->_dataStore.get() : nullptr;

  • trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm

    r242339 r247837  
    4141ALLOW_DEPRECATED_DECLARATIONS_BEGIN
    4242
    43 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     43ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    4444@implementation _WKWebsiteDataStore
    45 IGNORE_WARNINGS_END
     45ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    4646
    4747- (instancetype)initWithDataStore:(WKWebsiteDataStore *)dataStore

  • trunk/Source/WebKit/UIProcess/API/mac/WKView.mm

    r247058 r247837  
    7272#endif
    7373
    74 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     74ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    7575@implementation WKView
    76 IGNORE_WARNINGS_END
     76ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    7777
    7878- (id)initWithFrame:(NSRect)frame processGroup:(WKProcessGroup *)processGroup browsingContextGroup:(WKBrowsingContextGroup *)browsingContextGroup
    … …  
    178178}
    179179
    180 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     180ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    181181- (void)renewGState
    182 IGNORE_WARNINGS_END
     182ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    183183{
    184184    _data->_impl->renewGState();
    … …  
    693693
    694694#if ENABLE(DRAG_SUPPORT)
    695 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     695ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    696696- (void)draggedImage:(NSImage *)image endedAt:(NSPoint)endPoint operation:(NSDragOperation)operation
    697 IGNORE_WARNINGS_END
     697ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    698698{
    699699    _data->_impl->draggedImage(image, NSPointToCGPoint(endPoint), operation);
    … …  
    786786}
    787787
    788 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     788ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    789789- (BOOL)accessibilityIsIgnored
    790 IGNORE_WARNINGS_END
     790ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    791791{
    792792    return _data->_impl->accessibilityIsIgnored();
    … …  
    798798}
    799799
    800 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     800ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    801801- (id)accessibilityAttributeValue:(NSString *)attribute
    802 IGNORE_WARNINGS_END
     802ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    803803{
    804804    return _data->_impl->accessibilityAttributeValue(attribute);
    805805}
    806806
    807 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     807ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    808808- (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter
    809 IGNORE_WARNINGS_END
     809ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    810810{
    811811    return _data->_impl->accessibilityAttributeValue(attribute, parameter);
    812812}
    813813
    814 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     814ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    815815- (NSArray<NSString *> *)accessibilityParameterizedAttributeNames
    816 IGNORE_WARNINGS_END
     816ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    817817{
    818818    NSArray<NSString *> *names = [super accessibilityParameterizedAttributeNames];
    … …  
    885885}
    886886
    887 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     887ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    888888- (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
    889 IGNORE_WARNINGS_END
     889ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    890890{
    891891    return _data->_impl->namesOfPromisedFilesDroppedAtDestination(dropDestination);
    … …  
    11401140
    11411141ALLOW_DEPRECATED_DECLARATIONS_BEGIN
    1142 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     1142ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    11431143@implementation WKView (Private)
    1144 IGNORE_WARNINGS_END
     1144ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    11451145
    11461146- (void)saveBackForwardSnapshotForCurrentItem

  • trunk/Source/WebKit/UIProcess/WKImagePreviewViewController.mm

    r246583 r247837  
    9494
    9595#if HAVE(LINK_PREVIEW)
    96 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     96ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    9797- (NSArray<UIPreviewAction *> *)previewActionItems
    98 IGNORE_WARNINGS_END
     98ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    9999{
    100100    NSMutableArray<UIPreviewAction *> *previewActions = [NSMutableArray array];

  • trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm

    r244955 r247837  
    7474}
    7575
    76 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     76ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    7777- (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController
    78 IGNORE_WARNINGS_END
     78ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    7979{
    8080    if (popoverController != _popoverController)

  • trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm

    r246892 r247837  
    528528#pragma mark - UIPopoverControllerDelegate
    529529
    530 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     530ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    531531- (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController
    532 IGNORE_WARNINGS_END
     532ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    533533{
    534534    [self _cancel];

  • trunk/Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm

    r244955 r247837  
    168168}
    169169
    170 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     170ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    171171- (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController
    172 IGNORE_WARNINGS_END
     172ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    173173{
    174174    if (_isRotating)

  • trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm

    r247102 r247837  
    162162}
    163163
    164 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     164ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    165165- (BOOL)accessibilityIsIgnored
    166 IGNORE_WARNINGS_END
     166ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    167167{
    168168    return NO;
    … …  
    175175}
    176176
    177 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     177ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    178178- (id)accessibilityAttributeValue:(NSString *)attribute
    179 IGNORE_WARNINGS_END
     179ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    180180{
    181181    if ([attribute isEqualToString:NSAccessibilityParentAttribute])
    … …  
    219219}
    220220
    221 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     221ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    222222- (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter
    223 IGNORE_WARNINGS_END
     223ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    224224{
    225225    if ([attribute isEqualToString:NSAccessibilityBoundsForRangeParameterizedAttribute]) {
    … …  
    244244}
    245245
    246 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     246ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    247247- (NSArray *)accessibilityAttributeNames
    248 IGNORE_WARNINGS_END
     248ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    249249{
    250250    static NSArray *attributeNames = 0;
    … …  
    278278}
    279279
    280 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     280ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    281281- (NSArray *)accessibilityActionNames
    282 IGNORE_WARNINGS_END
     282ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    283283{
    284284#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
    … …  
    294294}
    295295
    296 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     296ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    297297- (void)accessibilityPerformAction:(NSString *)action
    298 IGNORE_WARNINGS_END
     298ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    299299{
    300300    if ([action isEqualToString:NSAccessibilityShowMenuAction])
    … …  
    302302}
    303303
    304 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     304ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    305305- (BOOL)accessibilityIsAttributeSettable:(NSString *)attribute
    306 IGNORE_WARNINGS_END
     306ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    307307{
    308308    return [_pdfLayerController accessibilityIsAttributeSettable:attribute];
    309309}
    310310
    311 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     311ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    312312- (void)accessibilitySetValue:(id)value forAttribute:(NSString *)attribute
    313 IGNORE_WARNINGS_END
     313ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    314314{
    315315    return [_pdfLayerController accessibilitySetValue:value forAttribute:attribute];
    316316}
    317317
    318 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     318ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    319319- (NSArray *)accessibilityParameterizedAttributeNames
    320 IGNORE_WARNINGS_END
     320ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    321321{
    322322#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300

  • trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm

    r243195 r247837  
    5959}
    6060
    61 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     61ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    6262- (BOOL)accessibilityIsIgnored
    63 IGNORE_WARNINGS_END
     63ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    6464{
    6565    return NO;
    6666}
    6767
    68 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     68ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    6969- (NSArray *)accessibilityAttributeNames
    70 IGNORE_WARNINGS_END
     70ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    7171{
    7272    if (!m_attributeNames)
    … …  
    9191}
    9292
    93 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     93ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    9494- (NSArray *)accessibilityParameterizedAttributeNames
    95 IGNORE_WARNINGS_END
     95ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    9696{
    9797    return retrieveAccessibilityValueFromMainThread<id>([&self] () -> id {
    … …  
    104104}
    105105
    106 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     106ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    107107- (BOOL)accessibilityIsAttributeSettable:(NSString *)attribute
    108 IGNORE_WARNINGS_END
     108ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    109109{
    110110    return NO;
    111111}
    112112
    113 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     113ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    114114- (void)accessibilitySetValue:(id)value forAttribute:(NSString *)attribute
    115 IGNORE_WARNINGS_END
     115ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    116116{
    117117}
    … …  
    124124}
    125125
    126 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     126ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    127127- (NSArray *)accessibilityActionNames
    128 IGNORE_WARNINGS_END
     128ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    129129{
    130130    return [NSArray array];
    … …  
    140140}
    141141
    142 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     142ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    143143- (id)accessibilityAttributeValue:(NSString *)attribute
    144 IGNORE_WARNINGS_END
     144ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    145145{
    146146    if (!WebCore::AXObjectCache::accessibilityEnabled())
    … …  
    215215}
    216216
    217 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     217ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    218218- (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter
    219 IGNORE_WARNINGS_END
     219ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    220220{
    221221    WebCore::FloatPoint pageOverlayPoint;

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r247722 r247837  
     12019-07-25  Dean Jackson  <dino@apple.com>
     2
     3        Add helper for ignoring deprecated implementation warnings
     4        https://bugs.webkit.org/show_bug.cgi?id=200135
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which
     9        is IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     10
     11        * Misc/WebDownload.mm:
     12        (-[WebDownload initWithRequest:delegate:]):
     13        * Misc/WebIconDatabase.mm:
     14        * Plugins/WebBaseNetscapePluginView.mm:
     15        (-[WebBaseNetscapePluginView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
     16        (-[WebBaseNetscapePluginView IGNORE_WARNINGS_END]): Deleted.
     17        * WebView/WebDynamicScrollBarsView.mm:
     18        (-[WebDynamicScrollBarsView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
     19        (-[WebDynamicScrollBarsView IGNORE_WARNINGS_END]): Deleted.
     20        * WebView/WebHTMLView.mm:
     21        (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
     22        (-[WebHTMLView draggedImage:endedAt:operation:]):
     23        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
     24        (-[WebHTMLView accessibilityAttributeValue:]):
     25        (-[WebHTMLView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
     26        (-[WebHTMLView characterIndexForPoint:]):
     27        (-[WebHTMLView firstRectForCharacterRange:]):
     28        (-[WebHTMLView attributedSubstringFromRange:]):
     29        (-[WebHTMLView setMarkedText:selectedRange:]):
     30        (-[WebHTMLView doCommandBySelector:]):
     31        (-[WebHTMLView insertText:]):
     32        (-[WebHTMLView IGNORE_WARNINGS_END]): Deleted.
     33
    1342019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
    235

  • trunk/Source/WebKitLegacy/mac/Misc/WebDownload.mm

    r243947 r247837  
    218218}
    219219
    220 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     220ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    221221- (id)initWithRequest:(NSURLRequest *)request delegate:(id<NSURLDownloadDelegate>)delegate
    222 IGNORE_WARNINGS_END
     222ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    223223{
    224224    [self _setRealDelegate:delegate];
    … …  
    226226}
    227227
    228 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     228ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    229229- (id)_initWithLoadingConnection:(NSURLConnection *)connection
    230230                         request:(NSURLRequest *)request
    … …  
    238238}
    239239
    240 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     240ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    241241- (id)_initWithRequest:(NSURLRequest *)request
    242242              delegate:(id)delegate

  • trunk/Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm

    r237266 r247837  
    9292    0xFC, 0x80, 0x00, 0x00, 0x27, 0x10, 0x00, 0x0A, 0xFC, 0x80, 0x00, 0x00, 0x27, 0x10 };
    9393
    94 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     94ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    9595@implementation WebIconDatabase
    96 IGNORE_WARNINGS_END
     96ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    9797
    9898+ (void)initialize

  • trunk/Source/WebKitLegacy/mac/Plugins/WebBaseNetscapePluginView.mm

    r246285 r247837  
    606606}
    607607
    608 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     608ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    609609- (void)renewGState
    610 IGNORE_WARNINGS_END
     610ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    611611{
    612612    [super renewGState];

  • trunk/Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm

    r236846 r247837  
    581581
    582582// This object will be the parent of the web area in WK1, so it should not be ignored.
    583 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     583ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    584584- (BOOL)accessibilityIsIgnored
    585 IGNORE_WARNINGS_END
     585ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    586586{
    587587    return NO;

  • trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm

    r247712 r247837  
    42734273
    42744274#if ENABLE(DRAG_SUPPORT) && PLATFORM(MAC)
    4275 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4275ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    42764276- (void)dragImage:(NSImage *)dragImage
    42774277               at:(NSPoint)at
    … …  
    43144314}
    43154315
    4316 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4316ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    43174317- (NSDragOperation)draggingSourceOperationMaskForLocal:(BOOL)isLocal
    4318 IGNORE_WARNINGS_END
     4318ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    43194319{
    43204320    ASSERT(![self _webView] || [self _isTopHTMLView]);
    … …  
    43274327}
    43284328
    4329 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4329ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    43304330- (void)draggedImage:(NSImage *)anImage endedAt:(NSPoint)aPoint operation:(NSDragOperation)operation
    4331 IGNORE_WARNINGS_END
     4331ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    43324332{
    43334333    ASSERT(![self _webView] || [self _isTopHTMLView]);
    … …  
    43664366}
    43674367
    4368 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     4368ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    43694369- (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
    4370 IGNORE_WARNINGS_END
     4370ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    43714371{
    43724372    NSFileWrapper *wrapper = nil;
    … …  
    50255025}
    50265026
    5027 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     5027ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    50285028- (id)accessibilityAttributeValue:(NSString*)attributeName
    5029 IGNORE_WARNINGS_END
     5029ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    50305030{
    50315031    if ([attributeName isEqualToString: NSAccessibilityChildrenAttribute]) {
    … …  
    62876287#if PLATFORM(MAC)
    62886288
    6289 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6289ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    62906290- (NSArray *)validAttributesForMarkedText
    6291 IGNORE_WARNINGS_END
     6291ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    62926292{
    62936293    static NSArray *validAttributes = [[NSArray alloc] initWithObjects:
    … …  
    63306330#endif // PLATFORM(MAC)
    63316331
    6332 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6332ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    63336333- (NSUInteger)characterIndexForPoint:(NSPoint)thePoint
    6334 IGNORE_WARNINGS_END
     6334ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    63356335{
    63366336    [self _executeSavedKeypressCommands];
    … …  
    63566356}
    63576357
    6358 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6358ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    63596359- (NSRect)firstRectForCharacterRange:(NSRange)theRange
    6360 IGNORE_WARNINGS_END
     6360ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    63616361{
    63626362    [self _executeSavedKeypressCommands];
    … …  
    63906390}
    63916391
    6392 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6392ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    63936393- (NSRange)selectedRange
    6394 IGNORE_WARNINGS_END
     6394ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    63956395{
    63966396    [self _executeSavedKeypressCommands];
    … …  
    64066406}
    64076407
    6408 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6408ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    64096409- (NSRange)markedRange
    6410 IGNORE_WARNINGS_END
     6410ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    64116411{
    64126412    [self _executeSavedKeypressCommands];
    … …  
    64246424#if PLATFORM(MAC)
    64256425
    6426 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6426ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    64276427- (NSAttributedString *)attributedSubstringFromRange:(NSRange)nsRange
    6428 IGNORE_WARNINGS_END
     6428ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    64296429{
    64306430    [self _executeSavedKeypressCommands];
    … …  
    64586458#endif
    64596459
    6460 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6460ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    64616461- (NSInteger)conversationIdentifier
    6462 IGNORE_WARNINGS_END
     6462ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    64636463{
    64646464    return (NSInteger)self;
    … …  
    64806480}
    64816481
    6482 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6482ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    64836483- (void)unmarkText
    6484 IGNORE_WARNINGS_END
     6484ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    64856485{
    64866486    [self _executeSavedKeypressCommands];
    … …  
    65276527#endif
    65286528
    6529 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6529ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    65306530- (void)setMarkedText:(id)string selectedRange:(NSRange)newSelRange
    6531 IGNORE_WARNINGS_END
     6531ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    65326532{
    65336533    [self _executeSavedKeypressCommands];
    … …  
    65856585}
    65866586
    6587 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6587ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    65886588- (void)doCommandBySelector:(SEL)selector
    6589 IGNORE_WARNINGS_END
     6589ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    65906590{
    65916591    LOG(TextInput, "doCommandBySelector:\"%s\"", sel_getName(selector));
    … …  
    66456645}
    66466646
    6647 IGNORE_WARNINGS_BEGIN("deprecated-implementations")
     6647ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
    66486648- (void)insertText:(id)string
    6649 IGNORE_WARNINGS_END
     6649ALLOW_DEPRECATED_IMPLEMENTATIONS_END
    66506650{
    66516651#if PLATFORM(MAC)
Note: See TracChangeset for help on using the changeset viewer.