Changeset 248085 in webkit

Timestamp:

Jul 31, 2019, 5:12:18 PM (7 years ago)

Author:

dino@apple.com

Message:

WKImagePreviewViewController not being autoreleased
​https://bugs.webkit.org/show_bug.cgi?id=200325
<rdar://problem/53788214>

Reviewed by Wenson Hsieh.

Wenson noticed I wasn't autoreleasing the WKImagePreviewViewController.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView continueContextMenuInteraction:]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-31  Dean Jackson  <dino@apple.com>
+
+        WKImagePreviewViewController not being autoreleased
+        https://bugs.webkit.org/show_bug.cgi?id=200325
+        <rdar://problem/53788214>
+
+        Reviewed by Wenson Hsieh.
+
+        Wenson noticed I wasn't autoreleasing the WKImagePreviewViewController.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView continueContextMenuInteraction:]):
+
 2019-07-31  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -7994 +7994 @@
                     return nil;
 
-                return [[WKImagePreviewViewController alloc] initWithCGImage:cgImage defaultActions:nil elementInfo:elementInfo.get()];
+                return [[[WKImagePreviewViewController alloc] initWithCGImage:cgImage defaultActions:nil elementInfo:elementInfo.get()] autorelease];
             };