Changeset 248277 in webkit

Timestamp:

Aug 5, 2019, 4:17:48 PM (7 years ago)

Author:

sbarati@apple.com

Message:

[WHLSL] Add compile time flag to dump metal compile times
​https://bugs.webkit.org/show_bug.cgi?id=200447

Reviewed by Myles C. Maxfield.

• Modules/webgpu/WHLSL/WHLSLPrepare.h:
• platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:

(WebCore::trySetFunctions):

• platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:

(WebCore::trySetFunctions):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webgpu/WHLSL/WHLSLPrepare.h (modified) (1 diff)
• platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm (modified) (2 diffs)
• platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-05  Saam Barati  <sbarati@apple.com>
+
+        [WHLSL] Add compile time flag to dump metal compile times
+        https://bugs.webkit.org/show_bug.cgi?id=200447
+
+        Reviewed by Myles C. Maxfield.
+
+        * Modules/webgpu/WHLSL/WHLSLPrepare.h:
+        * platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:
+        (WebCore::trySetFunctions):
+        * platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
+        (WebCore::trySetFunctions):
+
 2019-08-05  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.h

@@ -37 +37 @@
 namespace WHLSL {
 
+constexpr bool dumpMetalCompileTimes = false;
+
 struct RenderPrepareResult {
     String metalSource;

trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm

@@ -35 +35 @@
 #import <Metal/Metal.h>
 #import <wtf/BlockObjCExceptions.h>
+#import <wtf/DataLog.h>
+#import <wtf/MonotonicTime.h>
 #import <wtf/text/StringConcatenate.h>
 
@@ -86 +88 @@
 
         BEGIN_BLOCK_OBJC_EXCEPTIONS;
+        MonotonicTime startTime;
+        if (WHLSL::dumpMetalCompileTimes)
+            startTime = MonotonicTime::now();
         computeLibrary = adoptNS([device.platformDevice() newLibraryWithSource:whlslCompileResult->metalSource options:nil error:&error]);
+        if (WHLSL::dumpMetalCompileTimes)
+            dataLogLn("Metal compile times: ", (MonotonicTime::now() - startTime).milliseconds(), " ms");
         END_BLOCK_OBJC_EXCEPTIONS;
 #ifndef NDEBUG

trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm

@@ -38 +38 @@
 #import <wtf/BlockObjCExceptions.h>
 #import <wtf/CheckedArithmetic.h>
+#import <wtf/DataLog.h>
 #import <wtf/HashSet.h>
+#import <wtf/MonotonicTime.h>
 #import <wtf/OptionSet.h>
 #import <wtf/Optional.h>
@@ -398 +400 @@
 
         BEGIN_BLOCK_OBJC_EXCEPTIONS;
+        MonotonicTime startTime;
+        if (WHLSL::dumpMetalCompileTimes)
+            startTime = MonotonicTime::now();
         vertexLibrary = adoptNS([device.platformDevice() newLibraryWithSource:whlslCompileResult->metalSource options:nil error:&error]);
+        if (WHLSL::dumpMetalCompileTimes)
+            dataLogLn("Metal compile times: ", (MonotonicTime::now() - startTime).milliseconds(), " ms");
         END_BLOCK_OBJC_EXCEPTIONS;