Changeset 248278 in webkit

Timestamp:

Aug 5, 2019, 4:25:45 PM (7 years ago)

Author:

youenn@apple.com

Message:

RealtimeOutgoingAudioSource::pullAudioData is no longer needed
​https://bugs.webkit.org/show_bug.cgi?id=200450

Reviewed by Geoffrey Garen.

No change of behavior, removing base class method declaration.

• platform/mediastream/RealtimeOutgoingAudioSource.h:

(WebCore::RealtimeOutgoingAudioSource::pullAudioData): Deleted.

• platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h:
• platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/RealtimeOutgoingAudioSource.h (modified) (1 diff)
• platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h (modified) (1 diff)
• platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-05  Youenn Fablet  <youenn@apple.com>
+
+        RealtimeOutgoingAudioSource::pullAudioData is no longer needed
+        https://bugs.webkit.org/show_bug.cgi?id=200450
+
+        Reviewed by Geoffrey Garen.
+
+        No change of behavior, removing base class method declaration.
+
+        * platform/mediastream/RealtimeOutgoingAudioSource.h:
+        (WebCore::RealtimeOutgoingAudioSource::pullAudioData): Deleted.
+        * platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h:
+        * platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:
+
 2019-08-05  Saam Barati  <sbarati@apple.com>
 

trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h

@@ -75 +75 @@
     void unobserveSource();
 
-    virtual void pullAudioData() { }
-
     bool isSilenced() const { return m_muted || !m_enabled; }
 

trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h

@@ -47 +47 @@
     bool hasBufferedEnoughData() final;
 
-    void pullAudioData() final;
+    void pullAudioData();
 
     GUniquePtr<GstAudioConverter> m_sampleConverter;

trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h

@@ -53 +53 @@
     void sourceUpdated() final;
 
-    void pullAudioData() final;
+    void pullAudioData();
 
     Ref<AudioSampleDataSource> m_sampleConverter;