⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 248302 in webkit


Ignore:
Timestamp:
Aug 6, 2019, 10:34:27 AM (7 years ago)
Author:
jer.noble@apple.com
Message:

Add test for behavior introduced in r248174
​https://bugs.webkit.org/show_bug.cgi?id=200446

Reviewed by Eric Carlson.

Source/WebKit:

Add a new helper struct, FullscreenTouchSecheuristicParameters, and static getter,
iosParameters(), to allow the settings used by WKFullScreenViewController to be tested
in TestWebKitAPI. Make both of the Secheuristic classes privately exported as well.

  • UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:

(WebKit::FullscreenTouchSecheuristic::scoreOfNextTouch):
(WebKit::FullscreenTouchSecheuristic::reset):
(WebKit::FullscreenTouchSecheuristic::distanceScore):
(WebKit::FullscreenTouchSecheuristic::attenuationFactor):

  • UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.h:

(WebKit::FullscreenTouchSecheuristic::setParameters):
(WebKit::FullscreenTouchSecheuristic::requiredScore const):
(WebKit::FullscreenTouchSecheuristic::setRampUpSpeed):
(WebKit::FullscreenTouchSecheuristic::setRampDownSpeed):
(WebKit::FullscreenTouchSecheuristic::setXWeight):
(WebKit::FullscreenTouchSecheuristic::setYWeight):
(WebKit::FullscreenTouchSecheuristic::setGamma):
(WebKit::FullscreenTouchSecheuristic::setGammaCutoff):

  • UIProcess/ios/fullscreen/FullscreenTouchSecheuristicParameters.cpp: Copied from Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.h.

(WebKit::FullscreenTouchSecheuristicParameters::iosParameters):

  • UIProcess/ios/fullscreen/FullscreenTouchSecheuristicParameters.h: Copied from Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.h.
  • UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController initWithWebView:]):
(-[WKFullScreenViewController _touchDetected:]):

  • WebKit.xcodeproj/project.pbxproj:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.

(WebKit::configureSecheuristic):
(WebKit::TEST):

Location:
trunk
Files:
1 added
7 edited
2 copied

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r248293 r248302  
     12019-08-06  Jer Noble  <jer.noble@apple.com>
     2
     3        Add test for behavior introduced in r248174
     4        https://bugs.webkit.org/show_bug.cgi?id=200446
     5
     6        Reviewed by Eric Carlson.
     7
     8        Add a new helper struct, FullscreenTouchSecheuristicParameters, and static getter,
     9        iosParameters(), to allow the settings used by WKFullScreenViewController to be tested
     10        in TestWebKitAPI. Make both of the Secheuristic classes privately exported as well.
     11
     12        * UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:
     13        (WebKit::FullscreenTouchSecheuristic::scoreOfNextTouch):
     14        (WebKit::FullscreenTouchSecheuristic::reset):
     15        (WebKit::FullscreenTouchSecheuristic::distanceScore):
     16        (WebKit::FullscreenTouchSecheuristic::attenuationFactor):
     17        * UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.h:
     18        (WebKit::FullscreenTouchSecheuristic::setParameters):
     19        (WebKit::FullscreenTouchSecheuristic::requiredScore const):
     20        (WebKit::FullscreenTouchSecheuristic::setRampUpSpeed):
     21        (WebKit::FullscreenTouchSecheuristic::setRampDownSpeed):
     22        (WebKit::FullscreenTouchSecheuristic::setXWeight):
     23        (WebKit::FullscreenTouchSecheuristic::setYWeight):
     24        (WebKit::FullscreenTouchSecheuristic::setGamma):
     25        (WebKit::FullscreenTouchSecheuristic::setGammaCutoff):
     26        * UIProcess/ios/fullscreen/FullscreenTouchSecheuristicParameters.cpp: Copied from Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.h.
     27        (WebKit::FullscreenTouchSecheuristicParameters::iosParameters):
     28        * UIProcess/ios/fullscreen/FullscreenTouchSecheuristicParameters.h: Copied from Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.h.
     29        * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
     30        (-[WKFullScreenViewController initWithWebView:]):
     31        (-[WKFullScreenViewController _touchDetected:]):
     32        * WebKit.xcodeproj/project.pbxproj:
     33
    1342019-08-06  Claudio Saavedra  <csaavedra@igalia.com>
    235

  • trunk/Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp

    r237266 r248302  
    2727#include "FullscreenTouchSecheuristic.h"
    2828
    29 #if ENABLE(FULLSCREEN_API) && PLATFORM(IOS_FAMILY)
    30 
    3129#include <wtf/MonotonicTime.h>
    3230
    … …  
    3937    if (!m_lastTouchTime) {
    4038        m_lastTouchTime = WTFMove(now);
     39        return 0;
     40    }
     41
     42    Seconds deltaTime = now - m_lastTouchTime;
     43    m_lastTouchTime = now;
     44
     45    return scoreOfNextTouch(location, deltaTime);
     46}
     47
     48double FullscreenTouchSecheuristic::scoreOfNextTouch(CGPoint location, const Seconds& deltaTime)
     49{
     50    if (m_lastTouchLocation.x == -1 && m_lastTouchLocation.y ==  -1) {
    4151        m_lastTouchLocation = WTFMove(location);
    4252        return 0;
    4353    }
    4454
    45     Seconds deltaTime = now - m_lastTouchTime;
    46 
    4755    double coefficient = attenuationFactor(deltaTime);
    4856    m_lastScore = coefficient * distanceScore(location, m_lastTouchLocation, deltaTime) + (1 - coefficient) * m_lastScore;
    49 
    50     m_lastTouchTime = now;
    5157    m_lastTouchLocation = location;
    5258    return m_lastScore;
    … …  
    5662{
    5763    m_lastTouchTime = 0_s;
    58     m_lastTouchLocation = { };
     64    m_lastTouchLocation = { -1, -1 };
    5965    m_lastScore = 0;
    6066}
    … …  
    6369{
    6470    double distance = sqrt(
    65         m_xWeight * pow(nextLocation.x - lastLocation.x, 2) +
    66         m_yWeight * pow(nextLocation.y - lastLocation.y, 2));
     71        m_parameters.xWeight * pow(nextLocation.x - lastLocation.x, 2) +
     72        m_parameters.yWeight * pow(nextLocation.y - lastLocation.y, 2));
    6773    double sizeFactor = sqrt(
    68         m_xWeight * pow(m_size.width, 2) +
    69         m_yWeight * pow(m_size.height, 2));
     74        m_parameters.xWeight * pow(m_size.width, 2) +
     75        m_parameters.yWeight * pow(m_size.height, 2));
    7076    double scaledDistance = distance / sizeFactor;
    71     if (scaledDistance <= m_cutoff)
    72         return scaledDistance * (m_rampUpSpeed / deltaTime);
     77    if (scaledDistance <= m_parameters.gammaCutoff)
     78        return scaledDistance * (m_parameters.rampUpSpeed / deltaTime);
    7379
    74     double exponentialDistance = m_cutoff + pow((scaledDistance - m_cutoff) / (1 - m_cutoff), m_gamma);
    75     return exponentialDistance * (m_rampUpSpeed / deltaTime);
     80    double exponentialDistance = m_parameters.gammaCutoff + pow((scaledDistance - m_parameters.gammaCutoff) / (1 - m_parameters.gammaCutoff), m_parameters.gamma);
     81    return exponentialDistance * (m_parameters.rampUpSpeed / deltaTime);
    7682}
    7783
    7884double FullscreenTouchSecheuristic::attenuationFactor(Seconds delta)
    7985{
    80     double normalizedTimeDelta = delta / m_rampDownSpeed;
     86    double normalizedTimeDelta = delta / m_parameters.rampDownSpeed;
    8187    return std::max(std::min(normalizedTimeDelta * m_weight, 1.0), 0.0);
    8288}
    8389
    8490}
    85 
    86 #endif // ENABLE(FULLSCREEN_API) && PLATFORM(IOS_FAMILY)

  • trunk/Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.h

    r237266 r248302  
    2626#pragma once
    2727
    28 #if ENABLE(FULLSCREEN_API) && PLATFORM(IOS_FAMILY)
    29 
    30 #include <wtf/Seconds.h>
     28#include "FullscreenTouchSecheuristicParameters.h"
    3129
    3230namespace WebKit {
    … …  
    3432class FullscreenTouchSecheuristic {
    3533public:
    36     double scoreOfNextTouch(CGPoint location);
    37     void reset();
     34    WK_EXPORT double scoreOfNextTouch(CGPoint location);
     35    WK_EXPORT double scoreOfNextTouch(CGPoint location, const Seconds& deltaTime);
     36    WK_EXPORT void reset();
    3837
    39     void setRampUpSpeed(Seconds speed) { m_rampUpSpeed = speed; }
    40     void setRampDownSpeed(Seconds speed) { m_rampDownSpeed = speed; }
    41     void setXWeight(double weight) { m_xWeight = weight; }
    42     void setYWeight(double weight) { m_yWeight = weight; }
     38    void setParameters(const FullscreenTouchSecheuristicParameters& parameters) { m_parameters = parameters; }
     39    double requiredScore() const { return m_parameters.requiredScore; }
     40
     41    void setRampUpSpeed(Seconds speed) { m_parameters.rampUpSpeed = speed; }
     42    void setRampDownSpeed(Seconds speed) { m_parameters.rampDownSpeed = speed; }
     43    void setXWeight(double weight) { m_parameters.xWeight = weight; }
     44    void setYWeight(double weight) { m_parameters.yWeight = weight; }
    4345    void setSize(CGSize size) { m_size = size; }
    44     void setGamma(double gamma) { m_gamma = gamma; }
    45     void setGammaCutoff(double cutoff) { m_cutoff = cutoff; }
     46    void setGamma(double gamma) { m_parameters.gamma = gamma; }
     47    void setGammaCutoff(double cutoff) { m_parameters.gammaCutoff = cutoff; }
    4648
    4749private:
    48     double distanceScore(const CGPoint& nextLocation, const CGPoint& lastLocation, const Seconds& deltaTime);
    49     double attenuationFactor(Seconds delta);
     50    WK_EXPORT double distanceScore(const CGPoint& nextLocation, const CGPoint& lastLocation, const Seconds& deltaTime);
     51    WK_EXPORT double attenuationFactor(Seconds delta);
    5052
    5153    double m_weight { 0.1 };
    52     Seconds m_rampUpSpeed { 1 };
    53     Seconds m_rampDownSpeed { 1 };
    54     double m_xWeight { 1 };
    55     double m_yWeight { 1 };
    56     double m_gamma { 1 };
    57     double m_cutoff { 1 };
     54    FullscreenTouchSecheuristicParameters m_parameters;
    5855    CGSize m_size { };
    5956    Seconds m_lastTouchTime { 0 };
    60     CGPoint m_lastTouchLocation { };
     57    CGPoint m_lastTouchLocation { -1, -1 };
    6158    double m_lastScore { 0 };
    6259};
    6360
    6461}
    65 
    66 #endif // ENABLE(FULLSCREEN_API) && PLATFORM(IOS_FAMILY)

  • trunk/Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristicParameters.cpp

    r248301 r248302  
    11/*
    2  * Copyright (C) 2018 Apple Inc. All rights reserved.
     2 * Copyright (C) 2019 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    2424 */
    2525
    26 #pragma once
    27 
    28 #if ENABLE(FULLSCREEN_API) && PLATFORM(IOS_FAMILY)
    29 
    30 #include <wtf/Seconds.h>
     26#include "config.h"
     27#include "FullscreenTouchSecheuristicParameters.h"
    3128
    3229namespace WebKit {
    3330
    34 class FullscreenTouchSecheuristic {
    35 public:
    36     double scoreOfNextTouch(CGPoint location);
    37     void reset();
    38 
    39     void setRampUpSpeed(Seconds speed) { m_rampUpSpeed = speed; }
    40     void setRampDownSpeed(Seconds speed) { m_rampDownSpeed = speed; }
    41     void setXWeight(double weight) { m_xWeight = weight; }
    42     void setYWeight(double weight) { m_yWeight = weight; }
    43     void setSize(CGSize size) { m_size = size; }
    44     void setGamma(double gamma) { m_gamma = gamma; }
    45     void setGammaCutoff(double cutoff) { m_cutoff = cutoff; }
    46 
    47 private:
    48     double distanceScore(const CGPoint& nextLocation, const CGPoint& lastLocation, const Seconds& deltaTime);
    49     double attenuationFactor(Seconds delta);
    50 
    51     double m_weight { 0.1 };
    52     Seconds m_rampUpSpeed { 1 };
    53     Seconds m_rampDownSpeed { 1 };
    54     double m_xWeight { 1 };
    55     double m_yWeight { 1 };
    56     double m_gamma { 1 };
    57     double m_cutoff { 1 };
    58     CGSize m_size { };
    59     Seconds m_lastTouchTime { 0 };
    60     CGPoint m_lastTouchLocation { };
    61     double m_lastScore { 0 };
    62 };
     31FullscreenTouchSecheuristicParameters FullscreenTouchSecheuristicParameters::iosParameters()
     32{
     33    return {
     34        .rampUpSpeed = 0.25_s,
     35        .rampDownSpeed = 1_s,
     36        .xWeight = 0,
     37        .yWeight = 1,
     38        .gamma = 0.1,
     39        .gammaCutoff = 0.08,
     40        .requiredScore = 0.1,
     41    };
     42}
    6343
    6444}
    65 
    66 #endif // ENABLE(FULLSCREEN_API) && PLATFORM(IOS_FAMILY)

  • trunk/Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristicParameters.h

    r248301 r248302  
    11/*
    2  * Copyright (C) 2018 Apple Inc. All rights reserved.
     2 * Copyright (C) 2019 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    2626#pragma once
    2727
    28 #if ENABLE(FULLSCREEN_API) && PLATFORM(IOS_FAMILY)
    29 
     28#include "WKDeclarationSpecifiers.h"
    3029#include <wtf/Seconds.h>
    3130
    3231namespace WebKit {
    3332
    34 class FullscreenTouchSecheuristic {
    35 public:
    36     double scoreOfNextTouch(CGPoint location);
    37     void reset();
     33struct FullscreenTouchSecheuristicParameters {
     34    WTF::Seconds rampUpSpeed;
     35    WTF::Seconds rampDownSpeed;
     36    double xWeight;
     37    double yWeight;
     38    double gamma;
     39    double gammaCutoff;
     40    double requiredScore;
    3841
    39     void setRampUpSpeed(Seconds speed) { m_rampUpSpeed = speed; }
    40     void setRampDownSpeed(Seconds speed) { m_rampDownSpeed = speed; }
    41     void setXWeight(double weight) { m_xWeight = weight; }
    42     void setYWeight(double weight) { m_yWeight = weight; }
    43     void setSize(CGSize size) { m_size = size; }
    44     void setGamma(double gamma) { m_gamma = gamma; }
    45     void setGammaCutoff(double cutoff) { m_cutoff = cutoff; }
    46 
    47 private:
    48     double distanceScore(const CGPoint& nextLocation, const CGPoint& lastLocation, const Seconds& deltaTime);
    49     double attenuationFactor(Seconds delta);
    50 
    51     double m_weight { 0.1 };
    52     Seconds m_rampUpSpeed { 1 };
    53     Seconds m_rampDownSpeed { 1 };
    54     double m_xWeight { 1 };
    55     double m_yWeight { 1 };
    56     double m_gamma { 1 };
    57     double m_cutoff { 1 };
    58     CGSize m_size { };
    59     Seconds m_lastTouchTime { 0 };
    60     CGPoint m_lastTouchLocation { };
    61     double m_lastScore { 0 };
     42    WK_EXPORT static FullscreenTouchSecheuristicParameters iosParameters();
    6243};
    6344
    6445}
    65 
    66 #endif // ENABLE(FULLSCREEN_API) && PLATFORM(IOS_FAMILY)

  • trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

    r248174 r248302  
    4444static const NSTimeInterval pipHideAnimationDuration = 0.2;
    4545static const NSTimeInterval autoHideDelay = 4.0;
    46 static const double requiredScore = 0.1;
    4746
    4847@class WKFullscreenStackView;
    … …  
    184183    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_statusBarFrameDidChange:) name:UIApplicationDidChangeStatusBarFrameNotification object:nil];
    185184ALLOW_DEPRECATED_DECLARATIONS_END
    186     _secheuristic.setRampUpSpeed(Seconds(0.25));
    187     _secheuristic.setRampDownSpeed(Seconds(1.));
    188     _secheuristic.setXWeight(0);
    189     _secheuristic.setGamma(0.1);
    190     _secheuristic.setGammaCutoff(0.08);
     185    _secheuristic.setParameters(WebKit::FullscreenTouchSecheuristicParameters::iosParameters());
    191186
    192187    self._webView = webView;
    … …  
    532527    if ([_touchGestureRecognizer state] == UIGestureRecognizerStateEnded) {
    533528        double score = _secheuristic.scoreOfNextTouch([_touchGestureRecognizer locationInView:self.view]);
    534         if (score > requiredScore)
     529        if (score > _secheuristic.requiredScore())
    535530            [self _showPhishingAlert];
    536531    }

  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r248164 r248302  
    15941594                CD0C6831201FD10100A59409 /* WKFullScreenViewController.h in Headers */ = {isa = PBXBuildFile; fileRef = CD0C682F201FD10100A59409 /* WKFullScreenViewController.h */; };
    15951595                CD19A26E1A13E834008D650E /* WebDiagnosticLoggingClient.h in Headers */ = {isa = PBXBuildFile; fileRef = CD19A26A1A13E821008D650E /* WebDiagnosticLoggingClient.h */; };
    1596                 CD19D2EA2046406F0017074A /* FullscreenTouchSecheuristic.h in Headers */ = {isa = PBXBuildFile; fileRef = CD19D2E82046406F0017074A /* FullscreenTouchSecheuristic.h */; };
     1596                CD19D2EA2046406F0017074A /* FullscreenTouchSecheuristic.h in Headers */ = {isa = PBXBuildFile; fileRef = CD19D2E82046406F0017074A /* FullscreenTouchSecheuristic.h */; settings = {ATTRIBUTES = (Private, ); }; };
    15971597                CD2865EE2255562000606AC7 /* ProcessTaskStateObserver.h in Headers */ = {isa = PBXBuildFile; fileRef = CD2865EC2255562000606AC7 /* ProcessTaskStateObserver.h */; };
    15981598                CD2865EF2255562000606AC7 /* ProcessTaskStateObserver.mm in Sources */ = {isa = PBXBuildFile; fileRef = CD2865ED2255562000606AC7 /* ProcessTaskStateObserver.mm */; };
    … …  
    16171617                CDA29A2A1CBEB67A00901CCF /* PlaybackSessionManagerProxyMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDA29A261CBEB67A00901CCF /* PlaybackSessionManagerProxyMessageReceiver.cpp */; };
    16181618                CDA29A2B1CBEB67A00901CCF /* PlaybackSessionManagerProxyMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = CDA29A271CBEB67A00901CCF /* PlaybackSessionManagerProxyMessages.h */; };
     1619                CDA93DB022F8BCF400490A69 /* FullscreenTouchSecheuristicParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = CDA93DAE22F8BCF300490A69 /* FullscreenTouchSecheuristicParameters.h */; settings = {ATTRIBUTES = (Private, ); }; };
     1620                CDA93DB122F8BCF400490A69 /* FullscreenTouchSecheuristicParameters.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDA93DAF22F8BCF400490A69 /* FullscreenTouchSecheuristicParameters.cpp */; };
    16191621                CDC2831D201BD79D00E6E745 /* WKFullscreenStackView.h in Headers */ = {isa = PBXBuildFile; fileRef = CDC2831B201BD79D00E6E745 /* WKFullscreenStackView.h */; };
    16201622                CDCA85C9132ABA4E00E961DF /* WKFullScreenWindowController.h in Headers */ = {isa = PBXBuildFile; fileRef = CDCA85C7132ABA4E00E961DF /* WKFullScreenWindowController.h */; };
    … …  
    45614563                CDA29A261CBEB67A00901CCF /* PlaybackSessionManagerProxyMessageReceiver.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = PlaybackSessionManagerProxyMessageReceiver.cpp; path = DerivedSources/WebKit2/PlaybackSessionManagerProxyMessageReceiver.cpp; sourceTree = BUILT_PRODUCTS_DIR; };
    45624564                CDA29A271CBEB67A00901CCF /* PlaybackSessionManagerProxyMessages.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = PlaybackSessionManagerProxyMessages.h; path = DerivedSources/WebKit2/PlaybackSessionManagerProxyMessages.h; sourceTree = BUILT_PRODUCTS_DIR; };
     4565                CDA93DAE22F8BCF300490A69 /* FullscreenTouchSecheuristicParameters.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = FullscreenTouchSecheuristicParameters.h; path = ios/fullscreen/FullscreenTouchSecheuristicParameters.h; sourceTree = "<group>"; };
     4566                CDA93DAF22F8BCF400490A69 /* FullscreenTouchSecheuristicParameters.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = FullscreenTouchSecheuristicParameters.cpp; path = ios/fullscreen/FullscreenTouchSecheuristicParameters.cpp; sourceTree = "<group>"; };
    45634567                CDC2831B201BD79D00E6E745 /* WKFullscreenStackView.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = WKFullscreenStackView.h; path = ios/fullscreen/WKFullscreenStackView.h; sourceTree = "<group>"; };
    45644568                CDC2831C201BD79D00E6E745 /* WKFullscreenStackView.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = WKFullscreenStackView.mm; path = ios/fullscreen/WKFullscreenStackView.mm; sourceTree = "<group>"; };
    … …  
    89448948                                CD19D2E92046406F0017074A /* FullscreenTouchSecheuristic.cpp */,
    89458949                                CD19D2E82046406F0017074A /* FullscreenTouchSecheuristic.h */,
     8950                                CDA93DAE22F8BCF300490A69 /* FullscreenTouchSecheuristicParameters.h */,
     8951                                CDA93DAF22F8BCF400490A69 /* FullscreenTouchSecheuristicParameters.cpp */,
    89468952                                CDC2831B201BD79D00E6E745 /* WKFullscreenStackView.h */,
    89478953                                CDC2831C201BD79D00E6E745 /* WKFullscreenStackView.mm */,
    … …  
    1000110007                                1A445BA3184D5FCF004B3414 /* WKContextDownloadClient.h in Headers */,
    1000210008                                1A445BA1184D5FC1004B3414 /* WKContextHistoryClient.h in Headers */,
     10009                                CDA93DB022F8BCF400490A69 /* FullscreenTouchSecheuristicParameters.h in Headers */,
    1000310010                                1A445B9F184D5FB5004B3414 /* WKContextInjectedBundleClient.h in Headers */,
    1000410011                                5C795D70229F373F003FF1C4 /* WKContextMenuElementInfo.h in Headers */,
    … …  
    1114711154                                2D91344D212CF9F000128AFD /* PluginView.cpp in Sources */,
    1114811155                                2D54C31B212F4DA60049C174 /* ProcessLauncher.cpp in Sources */,
     11156                                CDA93DB122F8BCF400490A69 /* FullscreenTouchSecheuristicParameters.cpp in Sources */,
    1114911157                                CD2865EF2255562000606AC7 /* ProcessTaskStateObserver.mm in Sources */,
    1115011158                                2D72A1FA212BF46E00517A20 /* RemoteLayerTreeDrawingArea.mm in Sources */,

  • trunk/Tools/ChangeLog

    r248291 r248302  
     12019-08-06  Jer Noble  <jer.noble@apple.com>
     2
     3        Add test for behavior introduced in r248174
     4        https://bugs.webkit.org/show_bug.cgi?id=200446
     5
     6        Reviewed by Eric Carlson.
     7
     8        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
     9        * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
     10        (WebKit::configureSecheuristic):
     11        (WebKit::TEST):
     12
    1132019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
    214

  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r248139 r248302  
    871871                CDA3159D1ED5643F009F60D3 /* IOKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = CDA3159C1ED5643F009F60D3 /* IOKit.framework */; };
    872872                CDA4438E21F7A47700379489 /* ProcessSuspendMediaBuffering.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDA4438D21F7A47700379489 /* ProcessSuspendMediaBuffering.mm */; };
     873                CDA93DAD22F4F11E00490A69 /* FullscreenTouchSecheuristicTests.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDA93DAC22F4EC2200490A69 /* FullscreenTouchSecheuristicTests.cpp */; };
    873874                CDB4115A1E0B00DB00EAD352 /* video-with-muted-audio.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CDB411591E09DA8E00EAD352 /* video-with-muted-audio.html */; };
    874875                CDB5DFFF213610FA00D3E189 /* now-playing.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CDB5DFFE21360ED800D3E189 /* now-playing.html */; };
    … …  
    22982299                CDA3159C1ED5643F009F60D3 /* IOKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = IOKit.framework; path = System/Library/Frameworks/IOKit.framework; sourceTree = SDKROOT; };
    22992300                CDA4438D21F7A47700379489 /* ProcessSuspendMediaBuffering.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = ProcessSuspendMediaBuffering.mm; sourceTree = "<group>"; };
     2301                CDA93DAC22F4EC2200490A69 /* FullscreenTouchSecheuristicTests.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = FullscreenTouchSecheuristicTests.cpp; sourceTree = "<group>"; };
    23002302                CDB411591E09DA8E00EAD352 /* video-with-muted-audio.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "video-with-muted-audio.html"; sourceTree = "<group>"; };
    23012303                CDB5DFFE21360ED800D3E189 /* now-playing.html */ = {isa = PBXFileReference; lastKnownFileType = text.html; path = "now-playing.html"; sourceTree = "<group>"; };
    … …  
    30163018                                F4D4F3B71E4E36E400BB2767 /* DragAndDropTestsIOS.mm */,
    30173019                                F4BC0B132146C849002A0478 /* FocusPreservationTests.mm */,
     3020                                CDA93DAC22F4EC2200490A69 /* FullscreenTouchSecheuristicTests.cpp */,
    30183021                                F45E15722112CE2900307E82 /* KeyboardInputTestsIOS.mm */,
    30193022                                7560917719259C59009EF06E /* MemoryCacheAddImageToCacheIOS.mm */,
    … …  
    47934796                        files = (
    47944797                                9BD4239A1E04BD9800200395 /* AttributedSubstringForProposedRangeWithImage.mm in Sources */,
     4798                                CDA93DAD22F4F11E00490A69 /* FullscreenTouchSecheuristicTests.cpp in Sources */,
    47954799                                5C9D923122D7E0EB008E9266 /* ClassMethodSwizzler.mm in Sources */,
    47964800                                2E7765CD16C4D80A00BA2BB1 /* mainIOS.mm in Sources */,
Note: See TracChangeset for help on using the changeset viewer.