Changeset 248317 in webkit

Timestamp:

Aug 6, 2019, 2:57:52 PM (7 years ago)

Author:

Keith Rollin

Message:

Enable XCBuild for make and build-webkit builds
​https://bugs.webkit.org/show_bug.cgi?id=200476
<rdar://problem/50771065>

Reviewed by Jonathan Bedard.

All projects have now been tested under XCBuild and successfully
build. Enable the use of XCBuild when performing builds with make or
build-webkit and when using a sufficient version of Xcode. We set
this version to Xcode 11 since Xcode 10 -- even though it supports
XCBuild -- does not support a build facility needed to build WebKit
(Bug 197072, Bug 197116, Bug 197340).

Do not enable XCBuild in the Xcode projects themselves since these
projects may need to be used under older versions of Xcode and there's
no way to make those project changes sensitive to the version of Xcode
being used. This means that builds performed in the Xcode IDE will not
use XCBuild.

• Scripts/webkitdirs.pm:

(canUseXCBuild):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitdirs.pm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-06  Keith Rollin  <krollin@apple.com>
+
+        Enable XCBuild for `make` and `build-webkit` builds
+        https://bugs.webkit.org/show_bug.cgi?id=200476
+        <rdar://problem/50771065>
+
+        Reviewed by Jonathan Bedard.
+
+        All projects have now been tested under XCBuild and successfully
+        build. Enable the use of XCBuild when performing builds with `make` or
+        `build-webkit` and when using a sufficient version of Xcode. We set
+        this version to Xcode 11 since Xcode 10 -- even though it supports
+        XCBuild -- does not support a build facility needed to build WebKit
+        (Bug 197072, Bug 197116, Bug 197340).
+
+        Do not enable XCBuild in the Xcode projects themselves since these
+        projects may need to be used under older versions of Xcode and there's
+        no way to make those project changes sensitive to the version of Xcode
+        being used. This means that builds performed in the Xcode IDE will not
+        use XCBuild.
+
+        * Scripts/webkitdirs.pm:
+        (canUseXCBuild):
+
 2019-08-06  Chris Dumez  <cdumez@apple.com>
 

trunk/Tools/Scripts/webkitdirs.pm

@@ -904 +904 @@
 sub canUseXCBuild()
 {
+    if (`xcodebuild -version | grep "Build version"` =~ /Build version (\d+)([a-zA-Z])(\d+)([a-zA-Z]?)/) {
+        return $1 >= 11;
+    }
+
     return 0;
 }