⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 248342 in webkit


Ignore:
Timestamp:
Aug 6, 2019, 11:52:08 PM (7 years ago)
Author:
Kocsen Chung
Message:

Cherry-pick r247657. rdar://problem/54017957

Provide correct names for UIContextMenuInteraction API replacements
​https://bugs.webkit.org/show_bug.cgi?id=199966

Reviewed by Tim Horton.

We had some old incorrect names for replacements to SPI. While
here, I reordered and expanded the documentation for the new API.

  • UIProcess/API/Cocoa/WKUIDelegate.h:
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@247657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:
branches/safari-608.1-branch/Source/WebKit
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-608.1-branch/Source/WebKit/ChangeLog

    r248341 r248342  
     12019-08-06  Kocsen Chung  <kocsen_chung@apple.com>
     2
     3        Cherry-pick r247657. rdar://problem/54017957
     4
     5    Provide correct names for UIContextMenuInteraction API replacements
     6    https://bugs.webkit.org/show_bug.cgi?id=199966
     7   
     8    Reviewed by Tim Horton.
     9   
     10    We had some old incorrect names for replacements to SPI. While
     11    here, I reordered and expanded the documentation for the new API.
     12   
     13    * UIProcess/API/Cocoa/WKUIDelegate.h:
     14    * UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
     15   
     16    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     17
     18    2019-07-19  Dean Jackson  <dino@apple.com>
     19
     20            Provide correct names for UIContextMenuInteraction API replacements
     21            https://bugs.webkit.org/show_bug.cgi?id=199966
     22
     23            Reviewed by Tim Horton.
     24
     25            We had some old incorrect names for replacements to SPI. While
     26            here, I reordered and expanded the documentation for the new API.
     27
     28            * UIProcess/API/Cocoa/WKUIDelegate.h:
     29            * UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
     30
    1312019-08-06  Kocsen Chung  <kocsen_chung@apple.com>
    232

  • branches/safari-608.1-branch/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h

    r246598 r248342  
    175175
    176176/**
     177 * @abstract Called when the context menu will be presented.
     178 *
     179 * @param webView The web view invoking the delegate method.
     180 * @param elementInfo The elementInfo for the element the user is touching.
     181 */
     182
     183- (void)webView:(WKWebView *)webView contextMenuWillPresentForElement:(WKContextMenuElementInfo *)elementInfo WK_API_AVAILABLE(ios(WK_IOS_TBA));
     184
     185/**
    177186 * @abstract Called when the context menu configured by the UIContextMenuConfiguration from
    178  * webView:contextMenuConfigurationForElement:completionHandler: is committed.
     187 * webView:contextMenuConfigurationForElement:completionHandler: is committed. That is, when
     188 * the user has selected the view provided in the UIContextMenuContentPreviewProvider.
    179189 *
    180190 * @param webView The web view invoking the delegate method.
    … …  
    183193 */
    184194
    185 - (void)webView:(WKWebView *)webView contextMenuForElement:(WKContextMenuElementInfo *)elementInfo willCommitWithAnimator:(id<UIContextMenuInteractionCommitAnimating>)animator WK_API_AVAILABLE(ios(WK_IOS_TBA));
    186 
    187 /**
    188  * @abstract Called when the context menu will be presented.
    189  *
    190  * @param webView The web view invoking the delegate method.
    191  * @param elementInfo The elementInfo for the element the user is touching.
    192  */
    193 
    194 - (void)webView:(WKWebView *)webView contextMenuWillPresentForElement:(WKContextMenuElementInfo *)elementInfo WK_API_AVAILABLE(ios(WK_IOS_TBA));
    195 
    196 /**
    197  * @abstract Called when the context menu ends.
     195- (void)webView:(WKWebView *)webView contextMenuForElement:(WKContextMenuElementInfo *)elementInfo willCommitWithAnimator:(id <UIContextMenuInteractionCommitAnimating>)animator WK_API_AVAILABLE(ios(WK_IOS_TBA));
     196
     197/**
     198 * @abstract Called when the context menu ends, either by being dismissed or when a menu action is taken.
    198199 *
    199200 * @param webView The web view invoking the delegate method.

  • branches/safari-608.1-branch/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h

    r247308 r248342  
    145145
    146146- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForURL:(NSURL *)url WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuConfigurationForElement:completionHandler:", ios(9.0, WK_IOS_TBA));
    147 - (void)_webView:(WKWebView *)webView commitPreviewedViewController:(UIViewController *)previewedViewController WK_API_DEPRECATED_WITH_REPLACEMENT("webView:commitContextMenu:", ios(9.0, WK_IOS_TBA));
     147- (void)_webView:(WKWebView *)webView commitPreviewedViewController:(UIViewController *)previewedViewController WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuForElement:willCommitWithAnimator:", ios(9.0, WK_IOS_TBA));
    148148- (void)_webView:(WKWebView *)webView willPreviewImageWithURL:(NSURL *)imageURL WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuConfigurationForElement:completionHandler:", ios(9.0, WK_IOS_TBA));
    149 - (void)_webView:(WKWebView *)webView commitPreviewedImageWithURL:(NSURL *)imageURL WK_API_DEPRECATED_WITH_REPLACEMENT("webView:commitContextMenu:", ios(9.0, WK_IOS_TBA));
    150 - (void)_webView:(WKWebView *)webView didDismissPreviewViewController:(UIViewController *)previewedViewController committing:(BOOL)committing WK_API_DEPRECATED_WITH_REPLACEMENT("webView:dismissContextMenu:", ios(9.0, WK_IOS_TBA));
    151 - (void)_webView:(WKWebView *)webView didDismissPreviewViewController:(UIViewController *)previewedViewController WK_API_DEPRECATED_WITH_REPLACEMENT("webView:dismissContextMenu:", ios(9.0, WK_IOS_TBA));
     149- (void)_webView:(WKWebView *)webView commitPreviewedImageWithURL:(NSURL *)imageURL WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuForElement:willCommitWithAnimator:", ios(9.0, WK_IOS_TBA));
     150- (void)_webView:(WKWebView *)webView didDismissPreviewViewController:(UIViewController *)previewedViewController committing:(BOOL)committing WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuDidEndForElement:", ios(9.0, WK_IOS_TBA));
     151- (void)_webView:(WKWebView *)webView didDismissPreviewViewController:(UIViewController *)previewedViewController WK_API_DEPRECATED_WITH_REPLACEMENT("webView:contextMenuDidEndForElement:", ios(9.0, WK_IOS_TBA));
    152152
    153153#if TARGET_OS_IOS
Note: See TracChangeset for help on using the changeset viewer.