Changeset 248357 in webkit

Timestamp:

Aug 6, 2019, 11:52:57 PM (7 years ago)

Author:

Kocsen Chung

Message:

Cherry-pick r248085. rdar://problem/54017902

WKImagePreviewViewController not being autoreleased
​https://bugs.webkit.org/show_bug.cgi?id=200325
<rdar://problem/53788214>

Reviewed by Wenson Hsieh.

Wenson noticed I wasn't autoreleasing the WKImagePreviewViewController.

• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView continueContextMenuInteraction:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@248085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608.1-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

branches/safari-608.1-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-06  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Cherry-pick r248085. rdar://problem/54017902
+
+    WKImagePreviewViewController not being autoreleased
+    https://bugs.webkit.org/show_bug.cgi?id=200325
+    <rdar://problem/53788214>
+    
+    Reviewed by Wenson Hsieh.
+    
+    Wenson noticed I wasn't autoreleasing the WKImagePreviewViewController.
+    
+    * UIProcess/ios/WKContentViewInteraction.mm:
+    (-[WKContentView continueContextMenuInteraction:]):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-07-31  Dean Jackson  <dino@apple.com>
+
+            WKImagePreviewViewController not being autoreleased
+            https://bugs.webkit.org/show_bug.cgi?id=200325
+            <rdar://problem/53788214>
+
+            Reviewed by Wenson Hsieh.
+
+            Wenson noticed I wasn't autoreleasing the WKImagePreviewViewController.
+
+            * UIProcess/ios/WKContentViewInteraction.mm:
+            (-[WKContentView continueContextMenuInteraction:]):
+
 2019-08-06  Kocsen Chung  <kocsen_chung@apple.com>
 

branches/safari-608.1-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -7976 +7976 @@
                     return nil;
 
-                return [[WKImagePreviewViewController alloc] initWithCGImage:cgImage defaultActions:nil elementInfo:elementInfo.get()];
+                return [[[WKImagePreviewViewController alloc] initWithCGImage:cgImage defaultActions:nil elementInfo:elementInfo.get()] autorelease];
             };