⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 248361 in webkit


Ignore:
Timestamp:
Aug 6, 2019, 11:53:10 PM (7 years ago)
Author:
Kocsen Chung
Message:

Cherry-pick r248037. rdar://problem/54018119

AX: Re-enable accessibility/set-selected-text-range-after-newline.html test.
​https://bugs.webkit.org/show_bug.cgi?id=199431
<rdar://problem/52563340>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-07-31
Reviewed by Chris Fleizach.

Source/WebCore:

  • editing/Editing.cpp: (WebCore::visiblePositionForIndexUsingCharacterIterator):

LayoutTests:

  • TestExpectations:
  • accessibility/ios-simulator/set-selected-text-range-after-newline.html: Removed because it was the same as the one in the parent accessibility directory, so enabling it for iOS in ios-wk2/TestExpectations.
  • platform/ios-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@248037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:
branches/safari-608.1-branch
Files:
1 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-608.1-branch/LayoutTests/ChangeLog

    r248359 r248361  
     12019-08-06  Kocsen Chung  <kocsen_chung@apple.com>
     2
     3        Cherry-pick r248037. rdar://problem/54018119
     4
     5    AX: Re-enable accessibility/set-selected-text-range-after-newline.html test.
     6    https://bugs.webkit.org/show_bug.cgi?id=199431
     7    <rdar://problem/52563340>
     8   
     9    Patch by Andres Gonzalez <andresg_22@apple.com> on 2019-07-31
     10    Reviewed by Chris Fleizach.
     11   
     12    Source/WebCore:
     13   
     14    - Re-enabled LayoutTests/accessibility/set-selected-text-range-after-newline.html.
     15    - Put back workaround in visiblePositionForIndexUsingCharacterIterator
     16    that is needed for several accessibility issues.
     17    - This workaround was rolled back because it was thought the cause of:
     18    https://bugs.webkit.org/show_bug.cgi?id=199434
     19    It turned out that the actual cause of that hang was unrelated and was
     20    fixed in:
     21    https://bugs.webkit.org/show_bug.cgi?id=199845
     22   
     23    * editing/Editing.cpp:
     24    (WebCore::visiblePositionForIndexUsingCharacterIterator):
     25   
     26    LayoutTests:
     27   
     28    * TestExpectations:
     29    * accessibility/ios-simulator/set-selected-text-range-after-newline.html: Removed because it was the same as the one in the parent accessibility directory, so enabling it for iOS in ios-wk2/TestExpectations.
     30    * platform/ios-wk2/TestExpectations:
     31   
     32    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     33
     34    2019-07-31  Andres Gonzalez  <andresg_22@apple.com>
     35
     36            AX: Re-enable accessibility/set-selected-text-range-after-newline.html test.
     37            https://bugs.webkit.org/show_bug.cgi?id=199431
     38            <rdar://problem/52563340>
     39
     40            Reviewed by Chris Fleizach.
     41
     42            * TestExpectations:
     43            * accessibility/ios-simulator/set-selected-text-range-after-newline.html: Removed because it was the same as the one in the parent accessibility directory, so enabling it for iOS in ios-wk2/TestExpectations.
     44            * platform/ios-wk2/TestExpectations:
     45
    1462019-08-06  Kocsen Chung  <kocsen_chung@apple.com>
    247

  • branches/safari-608.1-branch/LayoutTests/TestExpectations

    r247632 r248361  
    22082208### START OF -disabled tests
    22092209
    2210 webkit.org/b/199431 accessibility/set-selected-text-range-after-newline.html [ Skip ]
    22112210webkit.org/b/20871 js/garbage-collect-after-string-appends.html [ Skip ]
    22122211webkit.org/b/58323 compositing/objects/composited-object-alignment.html [ Skip ]

  • branches/safari-608.1-branch/LayoutTests/platform/ios-wk2/TestExpectations

    r248131 r248361  
    2525editing/undo-manager [ Pass ]
    2626
     27accessibility/set-selected-text-range-after-newline.html [ Pass ]
    2728accessibility/smart-invert.html [ Pass ]
    2829accessibility/smart-invert-reference.html [ Pass ]
    … …  
    997998fast/replaced/border-radius-clip.html [ Failure ]
    998999accessibility/ios-simulator/press-fires-touch-events.html [ Skip ]
    999 webkit.org/b/199431 accessibility/ios-simulator/set-selected-text-range-after-newline.html [ Skip ]
    10001000
    10011001fast/text/combining-character-sequence-vertical.html [ ImageOnlyFailure ]

  • branches/safari-608.1-branch/Source/WebCore/ChangeLog

    r248359 r248361  
     12019-08-06  Kocsen Chung  <kocsen_chung@apple.com>
     2
     3        Cherry-pick r248037. rdar://problem/54018119
     4
     5    AX: Re-enable accessibility/set-selected-text-range-after-newline.html test.
     6    https://bugs.webkit.org/show_bug.cgi?id=199431
     7    <rdar://problem/52563340>
     8   
     9    Patch by Andres Gonzalez <andresg_22@apple.com> on 2019-07-31
     10    Reviewed by Chris Fleizach.
     11   
     12    Source/WebCore:
     13   
     14    - Re-enabled LayoutTests/accessibility/set-selected-text-range-after-newline.html.
     15    - Put back workaround in visiblePositionForIndexUsingCharacterIterator
     16    that is needed for several accessibility issues.
     17    - This workaround was rolled back because it was thought the cause of:
     18    https://bugs.webkit.org/show_bug.cgi?id=199434
     19    It turned out that the actual cause of that hang was unrelated and was
     20    fixed in:
     21    https://bugs.webkit.org/show_bug.cgi?id=199845
     22   
     23    * editing/Editing.cpp:
     24    (WebCore::visiblePositionForIndexUsingCharacterIterator):
     25   
     26    LayoutTests:
     27   
     28    * TestExpectations:
     29    * accessibility/ios-simulator/set-selected-text-range-after-newline.html: Removed because it was the same as the one in the parent accessibility directory, so enabling it for iOS in ios-wk2/TestExpectations.
     30    * platform/ios-wk2/TestExpectations:
     31   
     32    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     33
     34    2019-07-31  Andres Gonzalez  <andresg_22@apple.com>
     35
     36            AX: Re-enable accessibility/set-selected-text-range-after-newline.html test.
     37            https://bugs.webkit.org/show_bug.cgi?id=199431
     38            <rdar://problem/52563340>
     39
     40            Reviewed by Chris Fleizach.
     41
     42            - Re-enabled LayoutTests/accessibility/set-selected-text-range-after-newline.html.
     43            - Put back workaround in visiblePositionForIndexUsingCharacterIterator
     44            that is needed for several accessibility issues.
     45            - This workaround was rolled back because it was thought the cause of:
     46            https://bugs.webkit.org/show_bug.cgi?id=199434
     47            It turned out that the actual cause of that hang was unrelated and was
     48            fixed in:
     49            https://bugs.webkit.org/show_bug.cgi?id=199845
     50
     51            * editing/Editing.cpp:
     52            (WebCore::visiblePositionForIndexUsingCharacterIterator):
     53
    1542019-08-06  Kocsen Chung  <kocsen_chung@apple.com>
    255

  • branches/safari-608.1-branch/Source/WebCore/editing/Editing.cpp

    r247093 r248361  
    11231123    it.advance(index - 1);
    11241124
     1125    if (!it.atEnd() && it.text()[0] == '\n') {
     1126        // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines.
     1127        auto iteratorRange = it.range();
     1128        if (iteratorRange->startPosition() == iteratorRange->endPosition()) {
     1129            it.advance(1);
     1130            if (!it.atEnd())
     1131                return VisiblePosition(it.range()->startPosition());
     1132        }
     1133    }
     1134
    11251135    return { it.atEnd() ? range->endPosition() : it.range()->endPosition(), UPSTREAM };
    11261136}
Note: See TracChangeset for help on using the changeset viewer.