Changeset 248446 in webkit

Timestamp:

Aug 8, 2019, 3:57:10 PM (7 years ago)

Author:

Chris Dumez

Message:

Fix thread safety issue in AudioSampleDataSource() constructor
​https://bugs.webkit.org/show_bug.cgi?id=200547

Reviewed by Alex Christensen.

Make Logger ThreadSafeRefCounted as it is ref'd / deref'd from various
threads (including the main thread and the WebKitWebRTCAudioModule thread).

• wtf/Logger.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Logger.h (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-08-08  Chris Dumez  <cdumez@apple.com>
+
+        Fix thread safety issue in AudioSampleDataSource() constructor
+        https://bugs.webkit.org/show_bug.cgi?id=200547
+
+        Reviewed by Alex Christensen.
+
+        Make Logger ThreadSafeRefCounted as it is ref'd / deref'd from various
+        threads (including the main thread and the WebKitWebRTCAudioModule thread).
+
+        * wtf/Logger.h:
+
 2019-08-08  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/WTF/wtf/Logger.h

@@ -27 +27 @@
 
 #include <wtf/Lock.h>
+#include <wtf/ThreadSafeRefCounted.h>
 #include <wtf/text/StringBuilder.h>
 
@@ -107 +108 @@
 };
 
-class Logger : public RefCounted<Logger> {
+class Logger : public ThreadSafeRefCounted<Logger> {
     WTF_MAKE_NONCOPYABLE(Logger);
 public: