Changeset 248720 in webkit

Timestamp:

Aug 15, 2019, 10:15:15 AM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Uncaught Exception: Content request failed.
​https://bugs.webkit.org/show_bug.cgi?id=200704
<rdar://problem/54279372>

Reviewed by Brian Burg.

• UserInterface/Models/WebSocketResource.js:

(WI.WebSocketResource.prototype.requestContentFromBackend): Added.
Add an "assert not reached", as WebSocket resources don't really have "content", instead
having a list of send/receive frames.

• UserInterface/Views/ResourceClusterContentView.js:

(WI.ResourceClusterContentView.prototype._tryEnableCustomResponseContentView):
Don't attempt to request the content of any WI.WebSocketResource for the reason above.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/WebSocketResource.js (modified) (1 diff)
• UserInterface/Views/ResourceClusterContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-15  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Uncaught Exception: Content request failed.
+        https://bugs.webkit.org/show_bug.cgi?id=200704
+        <rdar://problem/54279372>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Models/WebSocketResource.js:
+        (WI.WebSocketResource.prototype.requestContentFromBackend): Added.
+        Add an "assert not reached", as WebSocket resources don't really have "content", instead
+        having a list of send/receive frames.
+
+        * UserInterface/Views/ResourceClusterContentView.js:
+        (WI.ResourceClusterContentView.prototype._tryEnableCustomResponseContentView):
+        Don't attempt to request the content of any `WI.WebSocketResource` for the reason above.
+
 2019-08-14  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js

@@ -86 +86 @@
     }
 
+    // Protected
+
+    requestContentFromBackend()
+    {
+        console.assert(false, "A WebSocket's content was requested. WebSockets do not have content so the request is nonsensical.");
+
+        return super.requestContentFromBackend();
+    }
+
     // Private
 

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js

@@ -365 +365 @@
             return;
 
+        // WebSocket resources already use a "custom" response content view.
+        if (this._resource instanceof WI.WebSocketResource)
+            return;
+
         this._resource.requestContent()
         .then(({error, content}) => {