Changeset 248745 in webkit

Timestamp:

Aug 15, 2019, 1:50:02 PM (7 years ago)

Author:

Alan Coon

Message:

Cherry-pick r248741. rdar://problem/54360841

Yellow Lookup highlight gets stuck over Mail messages
​https://bugs.webkit.org/show_bug.cgi?id=200778
<rdar://problem/53868514>

Reviewed by Wenson Hsieh.

• WebView/WebView.mm: (-[WebView _showDictionaryLookupPopup:]): Add a dismissal callback so that when Reveal hides the panel, it also dismisses the yellow indicator. This matches the behavior in modern WebKit.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@248741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608-branch/Source/WebKitLegacy/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebView.mm (modified) (2 diffs)

branches/safari-608-branch/Source/WebKitLegacy/mac/ChangeLog

@@ +1 @@
+2019-08-15  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r248741. rdar://problem/54360841
+
+    Yellow Lookup highlight gets stuck over Mail messages
+    https://bugs.webkit.org/show_bug.cgi?id=200778
+    <rdar://problem/53868514>
+    
+    Reviewed by Wenson Hsieh.
+    
+    * WebView/WebView.mm:
+    (-[WebView _showDictionaryLookupPopup:]):
+    Add a dismissal callback so that when Reveal hides the panel, it also
+    dismisses the yellow indicator. This matches the behavior in modern WebKit.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-08-15  Tim Horton  <timothy_horton@apple.com>
+
+            Yellow Lookup highlight gets stuck over Mail messages
+            https://bugs.webkit.org/show_bug.cgi?id=200778
+            <rdar://problem/53868514>
+
+            Reviewed by Wenson Hsieh.
+
+            * WebView/WebView.mm:
+            (-[WebView _showDictionaryLookupPopup:]):
+            Add a dismissal callback so that when Reveal hides the panel, it also
+            dismisses the yellow indicator. This matches the behavior in modern WebKit.
+
 2019-07-29  Alan Coon  <alancoon@apple.com>
 

branches/safari-608-branch/Source/WebKitLegacy/mac/WebView/WebView.mm

@@ -247 +247 @@
 #import <wtf/SoftLinking.h>
 #import <wtf/StdLibExtras.h>
+#import <wtf/WeakObjCPtr.h>
 #import <wtf/WorkQueue.h>
 #import <wtf/spi/darwin/dyldSPI.h>
@@ -9526 +9527 @@
     }, [self](FloatRect rectInRootViewCoordinates) {
         return [self _convertRectFromRootView:rectInRootViewCoordinates];
+    }, [weakSelf = WeakObjCPtr<WebView>(self)]() {
+        [weakSelf.get() _clearTextIndicatorWithAnimation:TextIndicatorWindowDismissalAnimation::FadeOut];
     });
 }