Changeset 248757 in webkit

Timestamp:

Aug 15, 2019, 6:58:38 PM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._resource.initiatorSourceCodeLocation')
​https://bugs.webkit.org/show_bug.cgi?id=200798

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WI.ResourceDetailsSidebarPanel.prototype.set resource):
(WI.ResourceDetailsSidebarPanel.prototype.layout):
Cancel the Throttler whenever the _resource is updated, as otherwise the Throttler may
fire later on with an unset _resource.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ResourceDetailsSidebarPanel.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-15  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._resource.initiatorSourceCodeLocation')
+        https://bugs.webkit.org/show_bug.cgi?id=200798
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/ResourceDetailsSidebarPanel.js:
+        (WI.ResourceDetailsSidebarPanel.prototype.set resource):
+        (WI.ResourceDetailsSidebarPanel.prototype.layout):
+        Cancel the `Throttler` whenever the `_resource` is updated, as otherwise the `Throttler` may
+        fire later on with an unset `_resource`.
+
 2019-08-15  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js

@@ -84 +84 @@
         if (this._resource && this._needsToRemoveResourceEventListeners) {
             this._resource.removeEventListener(null, null, this);
+            this._refreshRelatedResourcesSectionThrottler.cancel();
 
             this._needsToRemoveResourceEventListeners = false;
@@ -212 +213 @@
         this._refreshImageSizeSection();
         this._refreshRequestDataSection();
-        this._refreshRelatedResourcesSection();
+        this._refreshRelatedResourcesSectionThrottler.force();
     }