Changeset 248758 in webkit

Timestamp:

Aug 15, 2019, 7:08:29 PM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION(r244268): "Show Scope Chain on pause" setting has no effect
​https://bugs.webkit.org/show_bug.cgi?id=200797

Reviewed by Joseph Pecoraro.

• UserInterface/Views/DebuggerTabContentView.js:

(WI.DebuggerTabContentView.prototype.showDetailsSidebarPanels):

• UserInterface/Views/SourcesTabContentView.js:

(WI.SourcesTabContentView.prototype.showDetailsSidebarPanels):
When the sidebar panel isn't visible parentSidebar is null. Use WI.DetailsSidebar instead.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DebuggerTabContentView.js (modified) (1 diff)
• UserInterface/Views/SourcesTabContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-15  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r244268): "Show Scope Chain on pause" setting has no effect
+        https://bugs.webkit.org/show_bug.cgi?id=200797
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/DebuggerTabContentView.js:
+        (WI.DebuggerTabContentView.prototype.showDetailsSidebarPanels):
+        * UserInterface/Views/SourcesTabContentView.js:
+        (WI.SourcesTabContentView.prototype.showDetailsSidebarPanels):
+        When the sidebar panel isn't visible `parentSidebar` is `null`. Use `WI.DetailsSidebar` instead.
+
 2019-08-15  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js

@@ -81 +81 @@
             return;
 
-        let sidebar = scopeChainDetailsSidebarPanel.parentSidebar;
-        if (!sidebar)
-            return;
-
-        sidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
-        sidebar.collapsed = false;
+        WI.detailsSidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
+        WI.detailsSidebar.collapsed = false;
 
         this._showScopeChainDetailsSidebarPanel = false;

trunk/Source/WebInspectorUI/UserInterface/Views/SourcesTabContentView.js

@@ -84 +84 @@
             return;
 
-        let sidebar = scopeChainDetailsSidebarPanel.parentSidebar;
-        if (!sidebar)
-            return;
-
-        sidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
-        sidebar.collapsed = false;
+        WI.detailsSidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
+        WI.detailsSidebar.collapsed = false;
 
         this._showScopeChainDetailsSidebarPanel = false;