Changeset 248937 in webkit

Timestamp:

Aug 20, 2019 11:00:02 PM (5 years ago)

Author:

bshafiei@apple.com

Message:

Cherry-pick r248928. rdar://problem/54543351

[iOS] REGRESSION (248501): gmail.com images are still not shown on some versions of iPhone iOS13
​https://bugs.webkit.org/show_bug.cgi?id=200948

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-08-20
Reviewed by Tim Horton.

Apply the gmail.com quirk for all iPhone iOS versions till the gmail.com
bug is fixed.

• WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::platformUserAgent const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@248928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

branches/safari-608-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-20  Babak Shafiei  <bshafiei@apple.com>
+
+        Cherry-pick r248928. rdar://problem/54543351
+
+    [iOS] REGRESSION (248501): gmail.com images are still not shown on some versions of iPhone iOS13
+    https://bugs.webkit.org/show_bug.cgi?id=200948
+    
+    Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-08-20
+    Reviewed by Tim Horton.
+    
+    Apply the gmail.com quirk for all iPhone iOS versions till the gmail.com
+    bug is fixed.
+    
+    * WebProcess/WebPage/ios/WebPageIOS.mm:
+    (WebKit::WebPage::platformUserAgent const):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-08-20  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+            [iOS] REGRESSION (248501): gmail.com images are still not shown on some versions of iPhone iOS13
+            https://bugs.webkit.org/show_bug.cgi?id=200948
+
+            Reviewed by Tim Horton.
+
+            Apply the gmail.com quirk for all iPhone iOS versions till the gmail.com
+            bug is fixed.
+
+            * WebProcess/WebPage/ios/WebPageIOS.mm:
+            (WebKit::WebPage::platformUserAgent const):
+
 2019-08-20  Babak Shafiei  <bshafiei@apple.com>
 

branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -3792 +3792 @@
         return String();
 
-    if (document->quirks().shouldAvoidUsingIOS13ForGmail() && osNameForUserAgent() == "iPhone OS" && systemMarketingVersionForUserAgentString() == "13_1")
+    if (document->quirks().shouldAvoidUsingIOS13ForGmail() && osNameForUserAgent() == "iPhone OS")
         return standardUserAgentWithApplicationName({ }, "12_1_3");