Changeset 248985 in webkit

Timestamp:

Aug 21, 2019, 6:25:36 PM (7 years ago)

Author:

Kocsen Chung

Message:

Cherry-pick r248944. rdar://problem/54579628

REGRESSION: naver.com - Multiple taps are required to open email
​https://bugs.webkit.org/show_bug.cgi?id=200979
<rdar://problem/54295239>

Patch by Antoine Quint <Antoine Quint> on 2019-08-21
Reviewed by Dean Jackson.

The "click" events on subjects in the message list are prevented by preventDefault() being called from a "mouseup" event listener.
This shouldn't actually happen, but due to how simulated mouse events are implemented, there is no current distinction between
"touchend" and "mouseup" events. It is safe however to opt mail.naver.com out of simulated mouse events altogether.

• page/Quirks.cpp: (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@248944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)

branches/safari-608-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-21  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Cherry-pick r248944. rdar://problem/54579628
+
+    REGRESSION: naver.com - Multiple taps are required to open email
+    https://bugs.webkit.org/show_bug.cgi?id=200979
+    <rdar://problem/54295239>
+    
+    Patch by Antoine Quint <graouts@apple.com> on 2019-08-21
+    Reviewed by Dean Jackson.
+    
+    The "click" events on subjects in the message list are prevented by preventDefault() being called from a "mouseup" event listener.
+    This shouldn't actually happen, but due to how simulated mouse events are implemented, there is no current distinction between
+    "touchend" and "mouseup" events. It is safe however to opt mail.naver.com out of simulated mouse events altogether.
+    
+    * page/Quirks.cpp:
+    (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-08-21  Antoine Quint  <graouts@apple.com>
+
+            REGRESSION: naver.com - Multiple taps are required to open email
+            https://bugs.webkit.org/show_bug.cgi?id=200979
+            <rdar://problem/54295239>
+
+            Reviewed by Dean Jackson.
+
+            The "click" events on subjects in the message list are prevented by preventDefault() being called from a "mouseup" event listener.
+            This shouldn't actually happen, but due to how simulated mouse events are implemented, there is no current distinction between
+            "touchend" and "mouseup" events. It is safe however to opt mail.naver.com out of simulated mouse events altogether.
+
+            * page/Quirks.cpp:
+            (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+
 2019-08-20  Babak Shafiei  <bshafiei@apple.com>
 

branches/safari-608-branch/Source/WebCore/page/Quirks.cpp

@@ -324 +324 @@
         if (equalLettersIgnoringASCIICase(host, "tv.naver.com"))
             return false;
+        // Disable the quirk for mail.naver.com subdomain to be able to tap on mail subjects.
+        if (equalLettersIgnoringASCIICase(host, "mail.naver.com"))
+            return false;
         // Disable the quirk on the mobile site.
         // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.