Changeset 248986 in webkit

Timestamp:

Aug 21, 2019, 6:25:41 PM (7 years ago)

Author:

Kocsen Chung

Message:

Cherry-pick r248952. rdar://problem/54579626

[iOS] HLS streams disappear from Now Playing when paused on the lock screen
​https://bugs.webkit.org/show_bug.cgi?id=200951
<rdar://problem/54534301>

Reviewed by Eric Carlson.

The AVPlayerItemTracks will get recreated on occasion (during seeks, and when
changing buffering policy) which can result in a player which no longer reports
that it has audio, which in turn results in Now Playing no longer considering
the web page to be an eligable now playing application. Bridge this gap by also
taking AVPlayerItem.hasEnabledAudio into account when determining whether the
player has audio.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@248952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (modified) (1 diff)

branches/safari-608-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-21  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Cherry-pick r248952. rdar://problem/54579626
+
+    [iOS] HLS streams disappear from Now Playing when paused on the lock screen
+    https://bugs.webkit.org/show_bug.cgi?id=200951
+    <rdar://problem/54534301>
+    
+    Reviewed by Eric Carlson.
+    
+    The AVPlayerItemTracks will get recreated on occasion (during seeks, and when
+    changing buffering policy) which can result in a player which no longer reports
+    that it has audio, which in turn results in Now Playing no longer considering
+    the web page to be an eligable now playing application. Bridge this gap by also
+    taking AVPlayerItem.hasEnabledAudio into account when determining whether the
+    player has audio.
+    
+    * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+    (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-08-21  Jer Noble  <jer.noble@apple.com>
+
+            [iOS] HLS streams disappear from Now Playing when paused on the lock screen
+            https://bugs.webkit.org/show_bug.cgi?id=200951
+            <rdar://problem/54534301>
+
+            Reviewed by Eric Carlson.
+
+            The AVPlayerItemTracks will get recreated on occasion (during seeks, and when
+            changing buffering policy) which can result in a player which no longer reports
+            that it has audio, which in turn results in Now Playing no longer considering
+            the web page to be an eligable now playing application. Bridge this gap by also
+            taking AVPlayerItem.hasEnabledAudio into account when determining whether the
+            player has audio.
+
+            * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+            (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
+
 2019-08-21  Kocsen Chung  <kocsen_chung@apple.com>
 

branches/safari-608-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

@@ -1837 +1837 @@
         hasVideo |= (m_visualGroup && m_visualGroup->selectedOption());
 
+        // HLS streams will occasionally recreate all their tracks; during seek and after
+        // buffering policy changes. "debounce" notifications which result in no enabled
+        // audio tracks by also taking AVPlayerItem.hasEnabledAudio into account when determining
+        // whethere there is any audio present.
+        hasAudio |= m_cachedHasEnabledAudio;
+
         // Always says we have video if the AVPlayerLayer is ready for diaplay to work around
         // an AVFoundation bug which causes it to sometimes claim a track is disabled even