Changeset 248999 in webkit

Timestamp:

Aug 22, 2019, 2:40:25 AM (7 years ago)

Author:

Claudio Saavedra

Message:

[SOUP] NetworkProcessSoup does not initialize CacheOptions correctly
​https://bugs.webkit.org/show_bug.cgi?id=200886

Reviewed by Philippe Normand.

r247567 wrongly initializes CacheOptions in a local variable that is never used
instead of using NetworkProcess's member variable, that is later used by the
NetworkSession to initialize the cache.

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/soup/NetworkProcessSoup.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-22  Claudio Saavedra  <csaavedra@igalia.com>
+
+        [SOUP] NetworkProcessSoup does not initialize CacheOptions correctly
+        https://bugs.webkit.org/show_bug.cgi?id=200886
+
+        Reviewed by Philippe Normand.
+
+        r247567 wrongly initializes CacheOptions in a local variable that is never used
+        instead of using NetworkProcess's member variable, that is later used by the
+        NetworkSession to initialize the cache.
+
+        * NetworkProcess/soup/NetworkProcessSoup.cpp:
+        (WebKit::NetworkProcess::platformInitializeNetworkProcess):
+
 2019-08-21  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp

@@ -118 +118 @@
     SoupNetworkSession::clearOldSoupCache(FileSystem::directoryName(m_diskCacheDirectory));
 
-    OptionSet<NetworkCache::CacheOption> cacheOptions { NetworkCache::CacheOption::RegisterNotify };
+    m_cacheOptions = { NetworkCache::CacheOption::RegisterNotify };
 #if ENABLE(NETWORK_CACHE_SPECULATIVE_REVALIDATION)
     if (parameters.shouldEnableNetworkCacheSpeculativeRevalidation)
-        cacheOptions.add(NetworkCache::CacheOption::SpeculativeRevalidation);
+        m_cacheOptions.add(NetworkCache::CacheOption::SpeculativeRevalidation);
 #endif