Changeset 249028 in webkit

Timestamp:

Aug 22, 2019, 2:30:46 PM (7 years ago)

Author:

timothy_horton@apple.com

Message:

REGRESSION (r248974): fast/events/ios/select-all-with-existing-selection.html fails
​https://bugs.webkit.org/show_bug.cgi?id=201050

Reviewed by Wenson Hsieh.

• fast/events/ios/select-all-with-existing-selection.html:

The test as-written doesn't actually wait for the tap to complete before
continuing on with the test - it starts immediately when the focus event
fires. This results in the selection being changed by the single click
handler *after* focusing the field.

Rewrite the test to await completion of the tap before moving forward
instead of waiting for focus.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/ios/select-all-with-existing-selection.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-08-22  Tim Horton  <timothy_horton@apple.com>
+
+        REGRESSION (r248974): fast/events/ios/select-all-with-existing-selection.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=201050
+
+        Reviewed by Wenson Hsieh.
+
+        * fast/events/ios/select-all-with-existing-selection.html:
+        The test as-written doesn't actually wait for the tap to complete before
+        continuing on with the test - it starts immediately when the focus event
+        fires. This results in the selection being changed by the single click
+        handler *after* focusing the field.
+
+        Rewrite the test to await completion of the tap before moving forward
+        instead of waiting for focus.
+
 2019-08-22  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/LayoutTests/fast/events/ios/select-all-with-existing-selection.html

@@ -27 +27 @@
 }
 
-function runTest()
+async function runTest()
 {
     let testElement = document.getElementById("test");
     console.assert(testElement.value.indexOf("word") !== -1);
-    function handleFocus() {
-        document.addEventListener("selectionchange", testSelectAll, { once: true });
-        testElement.setSelectionRange(testElement.value.indexOf("word"), testElement.value.length);
-    }
-    testElement.addEventListener("focus", handleFocus, { once: true });
 
     if (window.testRunner)
-        UIHelper.activateElement(testElement);
+        await UIHelper.activateElement(testElement);
     else
         testElement.focus();
+
+    document.addEventListener("selectionchange", testSelectAll, { once: true });
+    testElement.setSelectionRange(testElement.value.indexOf("word"), testElement.value.length);
 }