Changeset 249029 in webkit

Timestamp:

Aug 22, 2019, 2:43:53 PM (7 years ago)

Author:

Keith Rollin

Message:

Remove logging that contains a URL
​https://bugs.webkit.org/show_bug.cgi?id=201052
<rdar://problem/54613204>

Reviewed by Chris Dumez.

checkURLReceivedFromWebProcess in WebProcessProxy.cpp contains an old
logging line that logs a URL. We don't log URLs any more for privacy
reasons, so remove this.

A search for WTFLogAlways.*url turns up other matches, but those are
either false positives or cases where the URLs are logged only on
demand by the developer as part of debugging.
checkURLReceivedFromWebProcess is the only place where a URL is logged
as a matter of course.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebProcessProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-22  Keith Rollin  <krollin@apple.com>
+
+        Remove logging that contains a URL
+        https://bugs.webkit.org/show_bug.cgi?id=201052
+        <rdar://problem/54613204>
+
+        Reviewed by Chris Dumez.
+
+        checkURLReceivedFromWebProcess in WebProcessProxy.cpp contains an old
+        logging line that logs a URL. We don't log URLs any more for privacy
+        reasons, so remove this.
+
+        A search for WTFLogAlways.*url turns up other matches, but those are
+        either false positives or cases where the URLs are logged only on
+        demand by the developer as part of debugging.
+        checkURLReceivedFromWebProcess is the only place where a URL is logged
+        as a matter of course.
+
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
+
 2019-08-22  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp

@@ -559 +559 @@
 
     // A Web process that was never asked to load a file URL should not ever ask us to do anything with a file URL.
-    WTFLogAlways("Received an unexpected URL from the web process: '%s'\n", url.string().utf8().data());
+    RELEASE_LOG_ERROR(Loading, "Received an unexpected URL from the web process");
     return false;
 }