Changeset 249034 in webkit

Timestamp:

Aug 22, 2019, 4:17:46 PM (7 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: console.dir should expand objects
​https://bugs.webkit.org/show_bug.cgi?id=152039
<rdar://problem/23816853>

Reviewed by Joseph Pecoraro.

Expand objects logged by console.dir but keep them collapsed when logged by console.log.

• UserInterface/Views/ConsoleMessageView.js:

(WI.ConsoleMessageView.prototype.render):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ConsoleMessageView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-22  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: console.dir should expand objects
+        https://bugs.webkit.org/show_bug.cgi?id=152039
+        <rdar://problem/23816853>
+
+        Reviewed by Joseph Pecoraro.
+
+        Expand objects logged by console.dir but keep them collapsed when logged by console.log.
+
+        * UserInterface/Views/ConsoleMessageView.js:
+        (WI.ConsoleMessageView.prototype.render):
+
 2019-08-22  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

@@ -100 +100 @@
         this._renderRepeatCount();
 
-        if (this._message.type === WI.ConsoleMessage.MessageType.Image) {
+        if (this._message.type === WI.ConsoleMessage.MessageType.Dir)
+            this.expand();
+        else if (this._message.type === WI.ConsoleMessage.MessageType.Image) {
             this._element.classList.add("console-image");
             this._element.addEventListener("contextmenu", this._handleContextMenu.bind(this));