Changeset 249038 in webkit

Timestamp:

Aug 22, 2019, 6:43:43 PM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Console: automatically select the "Evaluations" filter whenever running commands
​https://bugs.webkit.org/show_bug.cgi?id=201060

Reviewed by Timothy Hatcher.

If the Console is actively being filtered (e.g. not "All"), it can be confusing to run a
command, only to not see any results. We should automatically enable the "Evaluations"
filter in addition to any other existing filters in these cases.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.didAppendConsoleMessageView):

• UserInterface/Views/ScopeBarItem.js:

(WI.ScopeBarItem.prototype.set selected):
(WI.ScopeBarItem.prototype.toggle): Added.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/LogContentView.js (modified) (1 diff)
• UserInterface/Views/ScopeBarItem.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-22  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Console: automatically select the "Evaluations" filter whenever running commands
+        https://bugs.webkit.org/show_bug.cgi?id=201060
+
+        Reviewed by Timothy Hatcher.
+
+        If the Console is actively being filtered (e.g. not "All"), it can be confusing to run a
+        command, only to not see any results. We should automatically enable the "Evaluations"
+        filter in addition to any other existing filters in these cases.
+
+        * UserInterface/Views/LogContentView.js:
+        (WI.LogContentView.prototype.didAppendConsoleMessageView):
+        * UserInterface/Views/ScopeBarItem.js:
+        (WI.ScopeBarItem.prototype.set selected):
+        (WI.ScopeBarItem.prototype.toggle): Added.
+
 2019-08-22  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js

@@ -235 +235 @@
         target.connection.runAfterPendingDispatches(this._clearFocusableChildren.bind(this));
 
-        if (messageView instanceof WI.ConsoleCommandView || messageView.message instanceof WI.ConsoleCommandResultMessage)
-            this._markScopeBarItemUnread(WI.LogContentView.Scopes.Evaluations);
-        else
-            this._markScopeBarItemForMessageLevelUnread(messageView.message.level);
+        if (!this._scopeBar.item(WI.LogContentView.Scopes.All).selected) {
+            if (messageView instanceof WI.ConsoleCommandView || messageView.message instanceof WI.ConsoleCommandResultMessage)
+                this._scopeBar.item(WI.LogContentView.Scopes.Evaluations).toggle(true, {extendSelection: true});
+            else
+                this._markScopeBarItemForMessageLevelUnread(messageView.message.level);
+        }
 
         console.assert(messageView.element instanceof Element);

trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBarItem.js

@@ -78 +78 @@
     set selected(selected)
     {
-        if (this._selectedSetting.value === selected)
-            return;
-
-        this._element.classList.toggle("selected", selected);
-        this._selectedSetting.value = selected;
-
-        this.dispatchEventToListeners(WI.ScopeBarItem.Event.SelectionChanged, {
+        this.toggle(selected, {
             extendSelection: this._independent || (WI.modifierKeys.metaKey && !WI.modifierKeys.ctrlKey && !WI.modifierKeys.altKey && !WI.modifierKeys.shiftKey),
         });
@@ -106 +100 @@
     }
 
+    toggle(selected, {extendSelection} = {})
+    {
+        if (this._selectedSetting.value === selected)
+            return;
+
+        this._element.classList.toggle("selected", selected);
+        this._selectedSetting.value = selected;
+
+        this.dispatchEventToListeners(WI.ScopeBarItem.Event.SelectionChanged, {extendSelection});
+    }
+
     // Private