⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 249060 in webkit


Ignore:
Timestamp:
Aug 23, 2019, 12:21:32 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

REGRESSION: fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=201075
<rdar://problem/54491246>

Patch by Antoine Quint <Antoine Quint> on 2019-08-23
Reviewed by Daniel Bates.

This test was written very early on in the process of implementing Pointer Events and assumed events would keep
firing when scrolling occured. We need to add "touch-action: none" to ensure we get pointermove and pointerup
events. We also need to ensure that the interaction occurs over content otherwise events won't fire. Finally, we
pretty up the test a bit.

  • fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt:
  • fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r249059 r249060  
     12019-08-23  Antoine Quint  <graouts@apple.com>
     2
     3        REGRESSION: fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html is timing out
     4        https://bugs.webkit.org/show_bug.cgi?id=201075
     5        <rdar://problem/54491246>
     6
     7        Reviewed by Daniel Bates.
     8
     9        This test was written very early on in the process of implementing Pointer Events and assumed events would keep
     10        firing when scrolling occured. We need to add "touch-action: none" to ensure we get pointermove and pointerup
     11        events. We also need to ensure that the interaction occurs over content otherwise events won't fire. Finally, we
     12        pretty up the test a bit.
     13
     14        * fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt:
     15        * fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html:
     16
    1172019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
    218

  • trunk/LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt

    r237902 r249060  
    66
    77    pointerdown fired.
    8 Remove this when bug 19133 is fixed.
    98At least one pointermove was fired.
    109pointerup fired.

  • trunk/LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html

    r237902 r249060  
    1 <!DOCTYPE html><!-- webkit-test-runner [ experimental:PointerEventsEnabled=true ] -->
     1<!DOCTYPE html>
    22<html>
    33<head>
    … …  
    77        body {
    88            margin: none;
     9            touch-action: none;
    910        }
    1011    </style>
    … …  
    2122        function runTest()
    2223        {
    23             // FIXME: At the moment a touch listener is required due
    24             // to the way pointer events are dispatched.
    25             // https://bugs.webkit.org/show_bug.cgi?id=191333
    26             window.addEventListener("touchstart", (event) => {
    27                 debug("Remove this when bug 19133 is fixed.");
    28             });
     24            window.addEventListener("pointerdown", event => debug("pointerdown fired."));
    2925
    30             window.addEventListener("pointerdown", (event) => {
    31                 debug("pointerdown fired.");
    32             });
    33 
    34             seenMove = false;
    35             window.addEventListener("pointermove", (event) => {
     26            let seenMove = false;
     27            window.addEventListener("pointermove", event => {
    3628                if (!seenMove)
    3729                    debug("At least one pointermove was fired.");
    … …  
    3931            });
    4032
    41             window.addEventListener("pointerup", (event) => {
     33            window.addEventListener("pointerup", event => {
    4234                debug("pointerup fired.");
    4335                finishJSTest();
    4436            });
    4537
    46             if (window.testRunner) {
    47                 touchAndDragFromPointToPoint(50, 200, 60, 210).then(() => {
    48                     liftUpAtPoint(60, 210);
    49                 });
    50             }
     38            if (window.testRunner)
     39                touchAndDragFromPointToPoint(50, 50, 40, 40).then(() => liftUpAtPoint(40, 40));
    5140        }
    5241
Note: See TracChangeset for help on using the changeset viewer.