Changeset 249072 in webkit

Timestamp:

Aug 23, 2019, 3:54:48 PM (7 years ago)

Author:

timothy_horton@apple.com

Message:

REGRESSION (r248974): fast/events/ios/key-command-delete-to-end-of-paragraph.html is timing out on iOS
​https://bugs.webkit.org/show_bug.cgi?id=201091
<rdar://problem/54647731>

Reviewed by Megan Gardner.

• fast/events/ios/key-command-delete-to-end-of-paragraph.html:

The test as-written doesn't actually wait for the tap to complete before
continuing on with the test - it starts immediately when the focus event
fires. This results in the selection being changed by the single click
handler *after* focusing the field.

Rewrite the test to await completion of the tap before moving forward
instead of waiting for focus.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/ios/key-command-delete-to-end-of-paragraph.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-08-23  Tim Horton  <timothy_horton@apple.com>
+
+        REGRESSION (r248974): fast/events/ios/key-command-delete-to-end-of-paragraph.html is timing out on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=201091
+        <rdar://problem/54647731>
+
+        Reviewed by Megan Gardner.
+
+        * fast/events/ios/key-command-delete-to-end-of-paragraph.html:
+        The test as-written doesn't actually wait for the tap to complete before
+        continuing on with the test - it starts immediately when the focus event
+        fires. This results in the selection being changed by the single click
+        handler *after* focusing the field.
+
+        Rewrite the test to await completion of the tap before moving forward
+        instead of waiting for focus.
+
 2019-08-23  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/fast/events/ios/key-command-delete-to-end-of-paragraph.html

@@ -36 +36 @@
 }
 
-function runTest()
+async function runTest()
 {
     if (!window.testRunner)
@@ -49 +49 @@
             UIHelper.keyDown("k", ["ctrlKey"]);
     }
-    testElement.addEventListener("focus", handleFocus, { once: true });
-    if (window.testRunner)
-        UIHelper.activateElement(testElement);
+
+    if (window.testRunner) {
+        await UIHelper.activateElement(testElement);
+        handleFocus();
+    } else
+        testElement.addEventListener("focus", handleFocus, { once: true });
 }