Changeset 249076 in webkit

Timestamp:

Aug 23, 2019, 5:20:57 PM (7 years ago)

Author:

rniwa@webkit.org

Message:

REGRESSION (r248807): Objects stored in ElementRareData are leaked
​https://bugs.webkit.org/show_bug.cgi?id=200954

Reviewed by David Kilzer.

NodeRareData didn't have a virtual destructor. As a result, member variables
of ElementRareData did not get destructed properly.

• dom/NodeRareData.cpp:
• dom/NodeRareData.h:

(WebCore::NodeRareData::~NodeRareData):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/NodeRareData.cpp (modified) (1 diff)
• dom/NodeRareData.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-23  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION (r248807): Objects stored in ElementRareData are leaked
+        https://bugs.webkit.org/show_bug.cgi?id=200954
+
+        Reviewed by David Kilzer.
+
+        NodeRareData didn't have a virtual destructor. As a result, member variables
+        of ElementRareData did not get destructed properly.
+
+        * dom/NodeRareData.cpp:
+        * dom/NodeRareData.h:
+        (WebCore::NodeRareData::~NodeRareData):
+
 2019-08-23  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/dom/NodeRareData.cpp

@@ -37 +37 @@
 
 struct SameSizeAsNodeRareData {
-    unsigned m_bitfields : 20;
-    void* m_pointer[2];
+    unsigned m_frameCount;
+    void* m_pointer[3];
 };
 

trunk/Source/WebCore/dom/NodeRareData.h

@@ -274 +274 @@
     { }
 
+    virtual ~NodeRareData()
+    { }
+
     void clearNodeLists() { m_nodeLists = nullptr; }
     NodeListsNodeData* nodeLists() const { return m_nodeLists.get(); }