Changeset 249081 in webkit

Timestamp:

Aug 24, 2019, 6:16:41 AM (7 years ago)

Author:

Alan Bujtas

Message:

[LFC] Remove redundant Layout::Box::ElementType::TableRowGroup
​https://bugs.webkit.org/show_bug.cgi?id=201112
<rdar://problem/54663833>

Reviewed by Antti Koivisto.

Use Layout::Box::ElementType::TableBodyGroup instead.

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isPaddingApplicable const):

• layout/layouttree/LayoutBox.h:
• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createLayoutBox):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/layouttree/LayoutBox.cpp (modified) (1 diff)
• layout/layouttree/LayoutBox.h (modified) (1 diff)
• layout/layouttree/LayoutTreeBuilder.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-24  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Remove redundant Layout::Box::ElementType::TableRowGroup
+        https://bugs.webkit.org/show_bug.cgi?id=201112
+        <rdar://problem/54663833>
+
+        Reviewed by Antti Koivisto.
+
+        Use Layout::Box::ElementType::TableBodyGroup instead.
+
+        * layout/layouttree/LayoutBox.cpp:
+        (WebCore::Layout::Box::isPaddingApplicable const):
+        * layout/layouttree/LayoutBox.h:
+        * layout/layouttree/LayoutTreeBuilder.cpp:
+        (WebCore::Layout::TreeBuilder::createLayoutBox):
+
 2019-08-23  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp

@@ -367 +367 @@
 
     auto elementType = m_elementAttributes.value().elementType;
-    return elementType != ElementType::TableRowGroup
-        && elementType != ElementType::TableHeaderGroup
+    return elementType != ElementType::TableHeaderGroup
+        && elementType != ElementType::TableBodyGroup
         && elementType != ElementType::TableFooterGroup
         && elementType != ElementType::TableRow

trunk/Source/WebCore/layout/layouttree/LayoutBox.h

@@ -51 +51 @@
         TableRow,
         TableColumnGroup,
-        TableRowGroup,
         TableHeaderGroup,
         TableBodyGroup,

trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp

@@ -107 +107 @@
             if (element->hasTagName(HTMLNames::colgroupTag))
                 return Box::ElementAttributes { Box::ElementType::TableColumnGroup };
-            if (element->hasTagName(HTMLNames::tbodyTag))
-                return Box::ElementAttributes { Box::ElementType::TableRowGroup };
             if (element->hasTagName(HTMLNames::theadTag))
                 return Box::ElementAttributes { Box::ElementType::TableHeaderGroup };