Changeset 249083 in webkit

Timestamp:

Aug 24, 2019, 6:24:29 AM (7 years ago)

Author:

Alan Bujtas

Message:

[LFC][BFC] Non-inline formatting context(table, grid etc) root container should not collapse through.
​https://bugs.webkit.org/show_bug.cgi?id=201099
<rdar://problem/54658946>

Reviewed by Antti Koivisto.

I didn't manage to find it in the spec, but surely formatting contexts like table, grid and flex should behave like
block so that their vertical margins are not adjoining, when they have at least one inflow child.

• layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/blockformatting/BlockMarginCollapse.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-24  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][BFC] Non-inline formatting context(table, grid etc) root container should not collapse through.
+        https://bugs.webkit.org/show_bug.cgi?id=201099
+        <rdar://problem/54658946>
+
+        Reviewed by Antti Koivisto.
+
+        I didn't manage to find it in the spec, but surely formatting contexts like table, grid and flex should behave like
+        block so that their vertical margins are not adjoining, when they have at least one inflow child.
+
+        * layout/blockformatting/BlockMarginCollapse.cpp:
+        (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):
+
 2019-08-24  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp

@@ -409 +409 @@
         }
 
-        if (establishesBlockFormattingContext(layoutBox))
-            return false;
+        // A root of a non-inline formatting context (table, flex etc) with inflow descendants should not collapse through.
+        return false;
     }