Changeset 249086 in webkit

Timestamp:

Aug 24, 2019, 6:36:29 AM (7 years ago)

Author:

Alan Bujtas

Message:

[LFC][TFC] Add section renderers to the layout tree (THEAD/TBODY/TFOOT)
​https://bugs.webkit.org/show_bug.cgi?id=201114
<rdar://problem/54664992>

Reviewed by Antti Koivisto.

Section renderers (THEAD/TBODY/TFOOT) are direct children of the RenderTable. Let's include them in the layout tree as well.

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createTableStructure):
(WebCore::Layout::outputInlineRuns):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/layouttree/LayoutTreeBuilder.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-24  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][TFC] Add section renderers to the layout tree (THEAD/TBODY/TFOOT)
+        https://bugs.webkit.org/show_bug.cgi?id=201114
+        <rdar://problem/54664992>
+
+        Reviewed by Antti Koivisto.
+
+        Section renderers (THEAD/TBODY/TFOOT) are direct children of the RenderTable. Let's include them in the layout tree as well.
+
+        * layout/layouttree/LayoutTreeBuilder.cpp:
+        (WebCore::Layout::TreeBuilder::createTableStructure):
+        (WebCore::Layout::outputInlineRuns):
+
 2019-08-24  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp

@@ -216 +216 @@
     auto tableBox = makeUnique<Container>(Box::ElementAttributes { Box::ElementType::TableBox }, RenderStyle::clone(tableRenderer.style()));
     appendChild(tableWrapperBox, *tableBox);
-    while (tableChild) {
-        TreeBuilder::createSubTree(downcast<RenderElement>(*tableChild), *tableBox);
-        tableChild = tableChild->nextSibling();
+    auto* sectionRenderer = tableChild;
+    while (sectionRenderer) {
+        auto sectionBox = createLayoutBox(tableRenderer, *sectionRenderer);
+        appendChild(*tableBox, *sectionBox);
+        auto& sectionContainer = downcast<Container>(*sectionBox);
+        TreeBuilder::createSubTree(downcast<RenderElement>(*sectionRenderer), sectionContainer);
+        sectionBox.release();
+        sectionRenderer = sectionRenderer->nextSibling();
     }
     // Temporary
@@ -260 +265 @@
         if (inlineRun->textContext())
             stream << "inline text box";
-        else  
+        else
             stream << "inline box";
         stream << " at (" << inlineRun->logicalLeft() << "," << inlineRun->logicalTop() << ") size " << inlineRun->logicalWidth() << "x" << inlineRun->logicalHeight();