Changeset 249102 in webkit

Timestamp:

Aug 26, 2019, 10:21:28 AM (7 years ago)

Author:

Jonathan Bedard

Message:

run-webkit-tests: Cap the number of automatically booted simulators at 12
​https://bugs.webkit.org/show_bug.cgi?id=201139

Reviewed by Aakash Jain.

To make local development with simulators more pleasant, machines should
never automatically boot more than 12 simulators.

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDeviceManager.max_supported_simulators):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/xcode/simulated_device.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-26  Jonathan Bedard  <jbedard@apple.com>
+
+        run-webkit-tests: Cap the number of automatically booted simulators at 12
+        https://bugs.webkit.org/show_bug.cgi?id=201139
+
+        Reviewed by Aakash Jain.
+
+        To make local development with simulators more pleasant, machines should
+        never automatically boot more than 12 simulators.
+
+        * Scripts/webkitpy/xcode/simulated_device.py:
+        (SimulatedDeviceManager.max_supported_simulators):
+
 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py

@@ -68 +68 @@
     PROCESS_COUNT_ESTIMATE_PER_SIMULATOR_INSTANCE = 125
 
+    # Testing on iMac Pros has indicated that more than 12 simulators, even if we seem to have enough resources for them,
+    # results in diminishing returns.
+    MAX_NUMBER_OF_SIMULATORS = 12
+
     xcrun = '/usr/bin/xcrun'
     simulator_device_path = '~/Library/Developer/CoreSimulator/Devices'
@@ -418 +422 @@
             return 0
 
-        max_supported_simulators_for_hardware = min(host.executive.cpu_count() / 2, host.platform.total_bytes_memory() // SimulatedDeviceManager.MEMORY_ESTIMATE_PER_SIMULATOR_INSTANCE)
+        max_supported_simulators_for_hardware = min(
+            host.executive.cpu_count() // 2,
+            host.platform.total_bytes_memory() // SimulatedDeviceManager.MEMORY_ESTIMATE_PER_SIMULATOR_INSTANCE,
+            SimulatedDeviceManager.MAX_NUMBER_OF_SIMULATORS,
+        )
         max_supported_simulators_locally = (system_process_count_limit - current_process_count) // SimulatedDeviceManager.PROCESS_COUNT_ESTIMATE_PER_SIMULATOR_INSTANCE