Changeset 249130 in webkit

Timestamp:

Aug 26, 2019, 8:19:06 PM (7 years ago)

Author:

Chris Dumez

Message:

Change default value of window.open()'s url argument
​https://bugs.webkit.org/show_bug.cgi?id=200882

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

• web-platform-tests/html/browsers/the-window-object/window-open-defaults.window-expected.txt:

Source/WebCore:

Update default URL parameter value for window.open() to be "" instead of "about:blank", as per:

• ​https://github.com/whatwg/html/issues/4762

This aligns our behavior with other Web browser engines.

No new tests, rebaselined existing test.

• page/DOMWindow.idl:

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-defaults.window-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/DOMWindow.idl (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2019-08-26  Chris Dumez  <cdumez@apple.com>
+
+        Change default value of window.open()'s url argument
+        https://bugs.webkit.org/show_bug.cgi?id=200882
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaseline WPT test now that it is passing.
+
+        * web-platform-tests/html/browsers/the-window-object/window-open-defaults.window-expected.txt:
+
 2019-08-26  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-defaults.window-expected.txt

@@ -1 +1 @@
 
-FAIL window.open()'s url parameter default assert_unreached: Reached unreachable code
+PASS window.open()'s url parameter default 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-26  Chris Dumez  <cdumez@apple.com>
+
+        Change default value of window.open()'s url argument
+        https://bugs.webkit.org/show_bug.cgi?id=200882
+
+        Reviewed by Ryosuke Niwa.
+
+        Update default URL parameter value for window.open() to be "" instead of "about:blank", as per:
+        - https://github.com/whatwg/html/issues/4762
+
+        This aligns our behavior with other Web browser engines.
+
+        No new tests, rebaselined existing test.
+
+        * page/DOMWindow.idl:
+
 2019-08-26  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/page/DOMWindow.idl

@@ -78 +78 @@
     [Replaceable, DoNotCheckSecurityOnGetter] readonly attribute WindowProxy? parent;
     [CheckSecurityForNode] readonly attribute Element? frameElement;
-    [CallWith=ActiveWindow&FirstWindow, MayThrowException] WindowProxy? open(optional USVString url = "about:blank", optional DOMString target = "_blank", optional [TreatNullAs=EmptyString] DOMString features = "");
+    [CallWith=ActiveWindow&FirstWindow, MayThrowException] WindowProxy? open(optional USVString url = "", optional DOMString target = "_blank", optional [TreatNullAs=EmptyString] DOMString features = "");
 
     // The user agent.