Changeset 249134 in webkit

Timestamp:

Aug 27, 2019, 12:38:41 AM (7 years ago)

Author:

youenn@apple.com

Message:

Make MediaStreamTrackPrivate RefCounted
​https://bugs.webkit.org/show_bug.cgi?id=201040

Reviewed by Darin Adler.

MediaStreamTrackPrivate should not be ref/deref except from the main thread.
The only method called from a background thread is audioSamplesAvailable in which
it is unsafe to ref a MediaStreamTrackPrivate.
Make the track RefCounted will ensure that no ref/deref is made in background threads.
No observable change of behavior.

• platform/mediastream/MediaStreamTrackPrivate.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/MediaStreamTrackPrivate.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-27  Youenn Fablet  <youenn@apple.com>
+
+        Make MediaStreamTrackPrivate RefCounted
+        https://bugs.webkit.org/show_bug.cgi?id=201040
+
+        Reviewed by Darin Adler.
+
+        MediaStreamTrackPrivate should not be ref/deref except from the main thread.
+        The only method called from a background thread is audioSamplesAvailable in which
+        it is unsafe to ref a MediaStreamTrackPrivate.
+        Make the track RefCounted will ensure that no ref/deref is made in background threads.
+        No observable change of behavior.
+
+        * platform/mediastream/MediaStreamTrackPrivate.h:
+
 2019-08-26  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h

@@ -32 +32 @@
 #include "RealtimeMediaSource.h"
 #include <wtf/LoggerHelper.h>
+#include <wtf/RefCounted.h>
 #include <wtf/WeakPtr.h>
 
@@ -43 +44 @@
 
 class MediaStreamTrackPrivate final
-    : public ThreadSafeRefCounted<MediaStreamTrackPrivate, WTF::DestructionThread::Main>
+    : public RefCounted<MediaStreamTrackPrivate>
     , public CanMakeWeakPtr<MediaStreamTrackPrivate, WeakPtrFactoryInitialization::Eager>
     , public RealtimeMediaSource::Observer