Changeset 249151 in webkit

Timestamp:

Aug 27, 2019, 11:01:31 AM (7 years ago)

Author:

Jonathan Bedard

Message:

run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=201000
<rdar://problem/53778938>

Unreviewed follow-up fix.

• Scripts/webkitpy/port/darwin.py:

(DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
spindump call failed.

• Scripts/webkitpy/port/darwin_testcase.py:
• Scripts/webkitpy/port/ios_device_unittest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/darwin.py (modified) (1 diff)
• Scripts/webkitpy/port/darwin_testcase.py (modified) (1 diff)
• Scripts/webkitpy/port/ios_device_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-27  Jonathan Bedard  <jbedard@apple.com>
+
+        run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
+        https://bugs.webkit.org/show_bug.cgi?id=201000
+        <rdar://problem/53778938>
+
+        Unreviewed follow-up fix.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
+        spindump call failed.
+        * Scripts/webkitpy/port/darwin_testcase.py:
+        * Scripts/webkitpy/port/ios_device_unittest.py:
+
 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/darwin.py

@@ -182 +182 @@
 
                 # FIXME: Remove the fallback when we no longer support Catalina.
-                if not exit_code:
+                if exit_code:
                     host.executive.run_command(spindump_command)
                 host.filesystem.move_to_base_host(DarwinPort.tailspin_file_path(host, name, pid, str(tempdir)),

trunk/Tools/Scripts/webkitpy/port/darwin_testcase.py

@@ -110 +110 @@
         expected_stdout = """['/usr/bin/sudo', '-n', '/usr/bin/tailspin', 'save', '-n', '/__im_tmp/tmp_0_/test-42-tailspin-temp.txt']
 ['/usr/sbin/spindump', '-i', '/__im_tmp/tmp_0_/test-42-tailspin-temp.txt', '-file', '/__im_tmp/tmp_0_/test-42-tailspin.txt', '-noBulkSymbolication']
-['/usr/sbin/spindump', '-i', '/__im_tmp/tmp_0_/test-42-tailspin-temp.txt', '-file', '/__im_tmp/tmp_0_/test-42-tailspin.txt']
 """
         OutputCapture().assert_outputs(self, port.sample_process, args=['test', 42], expected_stdout=expected_stdout)

trunk/Tools/Scripts/webkitpy/port/ios_device_unittest.py

@@ -57 +57 @@
         expected_stdout = """['/usr/bin/tailspin', 'save', '-n', '/__im_tmp/tmp_0_/test-42-tailspin-temp.txt']
 ['/usr/sbin/spindump', '-i', '/__im_tmp/tmp_0_/test-42-tailspin-temp.txt', '-file', '/__im_tmp/tmp_0_/test-42-tailspin.txt', '-noBulkSymbolication']
-['/usr/sbin/spindump', '-i', '/__im_tmp/tmp_0_/test-42-tailspin-temp.txt', '-file', '/__im_tmp/tmp_0_/test-42-tailspin.txt']
 """
         OutputCapture().assert_outputs(self, port.sample_process, args=['test', 42], expected_stdout=expected_stdout)