⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 249152 in webkit


Ignore:
Timestamp:
Aug 27, 2019, 11:06:14 AM (7 years ago)
Author:
Wenson Hsieh
Message:

fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html times out on iPad
​https://bugs.webkit.org/show_bug.cgi?id=201182
<rdar://problem/54562829>

Reviewed by Tim Horton.

This test verifies that if the user taps outside of a scrollable container that is decelerating, the page will
observe a click event. This test currently behaves as expected on iPhone, but on iPad, the tap which is
intended to be outside the scrollable area ends up inside it, so a click event is never dispatched. Instead of
hard-coding the tap location, address this test failure by targetting a separate element outside of the
scrollable area.

  • fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r249147 r249152  
     12019-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html times out on iPad
     4        https://bugs.webkit.org/show_bug.cgi?id=201182
     5        <rdar://problem/54562829>
     6
     7        Reviewed by Tim Horton.
     8
     9        This test verifies that if the user taps outside of a scrollable container that is decelerating, the page will
     10        observe a click event. This test currently behaves as expected on iPhone, but on iPad, the tap which is
     11        intended to be outside the scrollable area ends up inside it, so a click event is never dispatched. Instead of
     12        hard-coding the tap location, address this test failure by targetting a separate element outside of the
     13        scrollable area.
     14
     15        * fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html:
     16
    1172019-08-26  Jer Noble  <jer.noble@apple.com>
    218

  • trunk/LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-overflow-after-tap-on-body.html

    r248433 r249152  
    2828    background: linear-gradient(to bottom, red 0%, green 50%, blue 100%);
    2929}
     30
     31#target {
     32    width: 100%;
     33    height: 50px;
     34    margin-top: 1em;
     35}
    3036</style>
    3137<body onload="runTest()">
    … …  
    3339        <div id="content"></div>
    3440    </div>
     41    <div id="target"></div>
    3542    <p id="description"></p>
    3643    <p id="console"></p>
    … …  
    6370    testPassed(`scroller.scrollTop passed ${minimumExpectedScrollTop}`);
    6471    removeEventListener("scroll", observeScrollEvent);
    65     await UIHelper.activateAt(160, 350);
     72    await UIHelper.activateElement(document.getElementById("target"));
    6673    noteTestProgress();
    6774}
Note: See TracChangeset for help on using the changeset viewer.