Changeset 249170 in webkit

Timestamp:

Aug 27, 2019 2:09:47 PM (5 years ago)

Author:

Simon Fraser

Message:

Minor optimization in InlineFlowBox::paintBoxDecorations()
​https://bugs.webkit.org/show_bug.cgi?id=201199

Reviewed by Zalan Bujtas.

This function can early return before computing localRect, which takes a bit of time (seen
on profiles).

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/InlineFlowBox.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-27  Simon Fraser  <simon.fraser@apple.com>
+
+        Minor optimization in InlineFlowBox::paintBoxDecorations()
+        https://bugs.webkit.org/show_bug.cgi?id=201199
+
+        Reviewed by Zalan Bujtas.
+
+        This function can early return before computing localRect, which takes a bit of time (seen
+        on profiles).
+
+        * rendering/InlineFlowBox.cpp:
+        (WebCore::InlineFlowBox::paintBoxDecorations):
+
 2019-08-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Source/WebCore/rendering/InlineFlowBox.cpp

@@ -1348 +1348 @@
         return;
 
+    // You can use p::first-line to specify a background. If so, the root line boxes for
+    // a line may actually have to paint a background.
+    if (parent() && !renderer().hasVisibleBoxDecorations())
+        return;
+    const RenderStyle& lineStyle = this->lineStyle();
+    if (!parent() && (!isFirstLine() || &lineStyle == &renderer().style()))
+        return;
+
     LayoutRect frameRect(this->frameRect());
     constrainToLineTopAndBottomIfNeeded(frameRect);
@@ -1354 +1362 @@
     LayoutRect localRect(frameRect);
     flipForWritingMode(localRect);
-
-    // You can use p::first-line to specify a background. If so, the root line boxes for
-    // a line may actually have to paint a background.
-    if (parent() && !renderer().hasVisibleBoxDecorations())
-        return;
-    const RenderStyle& lineStyle = this->lineStyle();
-    if (!parent() && (!isFirstLine() || &lineStyle == &renderer().style()))
-        return;
 
     LayoutPoint adjustedPaintoffset = paintOffset + localRect.location();