Changeset 249202 in webkit

Timestamp:

Aug 28, 2019, 9:42:40 AM (7 years ago)

Author:

Jonathan Bedard

Message:

results.webkit.org: Auto-expand single configurations
​https://bugs.webkit.org/show_bug.cgi?id=201218

Rubber-stamped by Aakash Jain.

• resultsdbpy/resultsdbpy/view/static/js/timeline.js:

(TimelineFromEndpoint.toString): Automatically expand timeline when only one
configuration has been specified.

• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:

(prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
is expanded or collapsed by default.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/js/timeline.js (modified) (2 diffs)
• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-28  Jonathan Bedard  <jbedard@apple.com>
+
+        results.webkit.org: Auto-expand single configurations
+        https://bugs.webkit.org/show_bug.cgi?id=201218
+
+        Rubber-stamped by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+        (TimelineFromEndpoint.toString): Automatically expand timeline when only one
+        configuration has been specified.
+        * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+        (prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
+        is expanded or collapsed by default.
+
 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js

@@ -722 +722 @@
                                 })));
                     });
-                    myTimeline = Timeline.ExpandableSeriesWithHeaderExpanderComponent(myTimeline, ...timelinesBySDK);
+                    myTimeline = Timeline.ExpandableSeriesWithHeaderExpanderComponent(myTimeline, {}, ...timelinesBySDK);
                 }
                 collapsedTimelines.push(myTimeline);
@@ -748 +748 @@
                         exporter: exporterFactory(allResults),
                     })),
+                {expanded: this.configurations.length <= 1},
                 ...collapsedTimelines
             ));

trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js

@@ -476 +476 @@
 }
 
-Timeline.ExpandableSeriesComponent = (mainSeries, subSerieses, exporter) => {
+Timeline.ExpandableSeriesComponent = (mainSeries, options, subSerieses, exporter) => {
     const ref = REF.createRef({
-        state: {expanded: false},
+        state: {expanded: options.expanded ? options.expanded : false},
         onStateUpdate: (element, stateDiff) => {
             if (stateDiff.expanded === false) {
@@ -506 +506 @@
 }
 
-Timeline.ExpandableHeaderComponent = (mainLabel, subLabels, exporter) => {
+Timeline.ExpandableHeaderComponent = (mainLabel, options, subLabels, exporter) => {
     const ref = REF.createRef({
-        state: {expanded: false},
+        state: {expanded: options.expanded ? options.expanded : false},
         onStateUpdate: (element, stateDiff) => {
             if (stateDiff.expanded === false)
@@ -532 +532 @@
 }
 
-Timeline.ExpandableSeriesWithHeaderExpanderComponent = (mainSeriesWithLable, ...subSeriesWithLable) => {
+Timeline.ExpandableSeriesWithHeaderExpanderComponent = (mainSeriesWithLable, options, ...subSeriesWithLable) => {
     const ref = REF.createRef({
-        state: {expanded: false},
+        state: {expanded: options.expanded ? options.expanded : false},
         onStateUpdate: (element, stateDiff) => {
             if (stateDiff.expanded === false)
@@ -559 +559 @@
     }));
     return {
-        header: Timeline.ExpandableHeaderComponent(`<a class="link-button" href="javascript:void(0)" ref="${ref}">+</a>` + mainLabel, subLabels, composer),
-        series: Timeline.ExpandableSeriesComponent(mainSeries, subSerieses, composer),
+        header: Timeline.ExpandableHeaderComponent(`<a class="link-button" href="javascript:void(0)" ref="${ref}">+</a>` + mainLabel, options, subLabels, composer),
+        series: Timeline.ExpandableSeriesComponent(mainSeries, options, subSerieses, composer),
     }
 }