Changeset 249226 in webkit

Timestamp:

Aug 28, 2019, 5:01:03 PM (7 years ago)

Author:

Wenson Hsieh

Message:

WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
​https://bugs.webkit.org/show_bug.cgi?id=201241
<rdar://problem/54317588>

Reviewed by Tim Horton.

For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
-dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
it believes that the web view has rejected the drop from being handled.

Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
to make sure that the web process has had time to send a response after each update.

• TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:

(-[DragAndDropSimulator _advanceProgress]):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
+        https://bugs.webkit.org/show_bug.cgi?id=201241
+        <rdar://problem/54317588>
+
+        Reviewed by Tim Horton.
+
+        For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
+        communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
+        the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
+        -dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
+        it believes that the web view has rejected the drop from being handled.
+
+        Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
+        to make sure that the web process has had time to send a response after each update.
+
+        * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
+        (-[DragAndDropSimulator _advanceProgress]):
+
 2019-08-28  Megan Gardner  <megan_gardner@apple.com>
 

trunk/Tools/TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm

@@ -625 +625 @@
     case DragAndDropPhaseEntered: {
         _lastKnownDropProposal = [[_webView dropInteractionDelegate] dropInteraction:[_webView dropInteraction] sessionDidUpdate:_dropSession.get()];
+        [_webView waitForNextPresentationUpdate];
         if (![self shouldAllowMoveOperation] && [_lastKnownDropProposal operation] == UIDropOperationMove)
             _lastKnownDropProposal = adoptNS([[UIDropProposal alloc] initWithDropOperation:UIDropOperationCancel]);