Changeset 249236 in webkit

Timestamp:

Aug 28, 2019, 8:01:39 PM (7 years ago)

Author:

Simon Fraser

Message:

Make FillLayer::hasImage() inline
​https://bugs.webkit.org/show_bug.cgi?id=201265

Reviewed by Zalan Bujtas.

FillLayer::hasImage() shows up on profiles because it's called from hot functions like
isTransparent() and hasMask(), so make a basic inline version that doens't have
to walk the list.

• rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasImageInAnyLayer const):
(WebCore::FillLayer::hasImage const): Deleted.

• rendering/style/FillLayer.h:

(WebCore::FillLayer::hasImage const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/style/FillLayer.cpp (modified) (1 diff)
• rendering/style/FillLayer.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-28  Simon Fraser  <simon.fraser@apple.com>
+
+        Make FillLayer::hasImage() inline
+        https://bugs.webkit.org/show_bug.cgi?id=201265
+
+        Reviewed by Zalan Bujtas.
+
+        FillLayer::hasImage() shows up on profiles because it's called from hot functions like
+        isTransparent() and hasMask(), so make a basic inline version that doens't have
+        to walk the list.
+
+        * rendering/style/FillLayer.cpp:
+        (WebCore::FillLayer::hasImageInAnyLayer const):
+        (WebCore::FillLayer::hasImage const): Deleted.
+        * rendering/style/FillLayer.h:
+        (WebCore::FillLayer::hasImage const):
+
 2019-08-28  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebCore/rendering/style/FillLayer.cpp

@@ -366 +366 @@
 }
 
-bool FillLayer::hasImage() const
+bool FillLayer::hasImageInAnyLayer() const
 {
     for (auto* layer = this; layer; layer = layer->m_next.get()) {

trunk/Source/WebCore/rendering/style/FillLayer.h

@@ -146 +146 @@
     bool containsImage(StyleImage&) const;
     bool imagesAreLoaded() const;
-    bool hasImage() const;
+    bool hasImage() const { return m_next ? hasImageInAnyLayer() : m_image; }
     bool hasFixedImage() const;
     bool hasOpaqueImage(const RenderElement&) const;
@@ -176 +176 @@
 
     void computeClipMax() const;
+
+    bool hasImageInAnyLayer() const;
 
     std::unique_ptr<FillLayer> m_next;