Changeset 249245 in webkit

Timestamp:

Aug 28, 2019, 11:26:38 PM (7 years ago)

Author:

Fujii Hironori

Message:

[Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
​https://bugs.webkit.org/show_bug.cgi?id=201215

Reviewed by Don Olmstead.

MiniBrowser crashed if it was going to go to a unreachable page
because WKPageCopyActiveURL returned a nullptr.

• MiniBrowser/win/WebKitBrowserWindow.cpp:

(createString): Added null checking of the argument.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/win/WebKitBrowserWindow.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
+        https://bugs.webkit.org/show_bug.cgi?id=201215
+
+        Reviewed by Don Olmstead.
+
+        MiniBrowser crashed if it was going to go to a unreachable page
+        because WKPageCopyActiveURL returned a nullptr.
+
+        * MiniBrowser/win/WebKitBrowserWindow.cpp:
+        (createString): Added null checking of the argument.
+
 2019-08-28  Tim Horton  <timothy_horton@apple.com>
 

trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp

@@ -50 +50 @@
 std::wstring createString(WKURLRef wkURL)
 {
+    if (!wkURL)
+        return { };
     WKRetainPtr<WKStringRef> url = adoptWK(WKURLCopyString(wkURL));
     return createString(url.get());